Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the fmt pseudo CXX_MODULE #4256

Closed
wants to merge 1 commit into from
Closed

Restructure the fmt pseudo CXX_MODULE #4256

wants to merge 1 commit into from

Conversation

ClausKlein
Copy link

@ClausKlein ClausKlein commented Dec 5, 2024 •
edited
Loading

I have massive problems to work with fmt as CXX_MODULE?

I have just merged my fmt.cppm with your fmt.cc file.

It does not help, not usable!

see #4255

and https://github.com/ClausKlein/fmt-module

@ClausKlein ClausKlein marked this pull request as draft December 5, 2024 19:46
@vitaut
Copy link
Contributor

vitaut commented Dec 8, 2024

The changes look incorrect. In particular FMT_MODULE checks are redundant in fmt.cc. I suggest experimenting in your own fork and submitting a PR once the changes are in a reviewable state.

@vitaut vitaut closed this Dec 8, 2024
@ClausKlein
Copy link
Author

ClausKlein commented Dec 8, 2024 •
edited
Loading

Your Module is not tested and can't be imported in other modules!

Either you import std; or you #include <std headers>, not both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClausKlein @vitaut