Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove delay hack when positioning the caret after applying formatting #50

Merged
merged 12 commits into from
Aug 25, 2023
Merged

fix: remove delay hack when positioning the caret after applying formatting #50

merged 12 commits into from
Aug 25, 2023

Conversation

fmaclen
Copy link
Owner

@fmaclen fmaclen commented Aug 25, 2023 •
edited
Loading

  • Replace the setTimeout hack for a loop that waits that the length of the formattedValue has changed.
  • A new field was introduced in the last PR and forgot to properly update the tests.

@fmaclen fmaclen changed the title chore: update tests and improve resiliency fix: remove delay hack when positioning the caret after applying formatting Aug 25, 2023
@fmaclen fmaclen merged commit 33cc93a into main Aug 25, 2023
1 check passed
@fmaclen fmaclen deleted the fix_tests branch August 25, 2023 15:54
@github-actions
Copy link

🎉 This PR is included in version 0.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmaclen