-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: generate snapshots in CI (#190)
Closes #189 - Integration tests now run on `ubuntu-latest`. - We run Playwright with the `--update-snapshots` flag. - If the UI is updated it will automatically generate the new snapshot and if the tests passed a Github bot will commit those new snapshots to the PR, that way we can review UI changes together with the code. - Also added a new [`--reporter=list`](https://playwright.dev/docs/test-reporters#list-reporter) flag so we can see the status of each test as they run in the CI logs. - Updated `package.json` so when we run `npm test` locally we use the `--ignore-snapshots` flag, otherwise our local tests will always fail due to the differences between macOS and Linux renderers. This workflow may have have some unexpected behaviors but I'm willing to give it a shot and see how it plays out. One, potentially annoying, thing is that after you commit your changes to the branch, you will then have to pull the new snapshots once the tests are finished. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
1e567bd
commit 783e407
Showing
8 changed files
with
28 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: Lint | ||
name: ESLint | ||
|
||
on: | ||
pull_request: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.