Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix h5py issues, hydra compatibility, YAML config, and support for DataFrames/CSV files #1

Merged
merged 12 commits into from
Apr 16, 2024

Conversation

felixp8
Copy link
Collaborator

@felixp8 felixp8 commented Apr 7, 2024

  • Remove related packages from README
  • Introduce H5Reader object to avoid persistent read file handles at the mercy of the garbage collector that may interfere with subsequent writes/extends.
  • Switch from saving _meta.yaml as JSON to using YAML, while still supporting legacy JSON reading
  • Avoid treating dunder attributes (with format __*__, e.g., __file__) as normal keys for attribute access, for compatibility with hydra instantiation
  • Save/read pd.DataFrame objects as CSV instead of arrays
  • Introduce single-threaded SWMR test that reproduces past h5py file lock issue but is fixed with H5Reader changes

Copy link
Collaborator

@lappalainenj lappalainenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes and enhancements! Minor comments below

datamate/directory.py Outdated Show resolved Hide resolved
datamate/directory.py Outdated Show resolved Hide resolved
datamate/directory.py Outdated Show resolved Hide resolved
tests/test_swmr.py Outdated Show resolved Hide resolved
@lappalainenj lappalainenj merged commit 1ae4849 into main Apr 16, 2024
1 check passed
@lappalainenj lappalainenj deleted the h5py-fix branch April 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants