Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

WIP F-Droid market #698

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

WIP F-Droid market #698

wants to merge 45 commits into from

Conversation

btry
Copy link
Contributor

@btry btry commented Aug 21, 2018 •
edited by DIOHz0r
Loading

rebase of #193

provides a way to get apps from fdroid, download them as new packages and update them automatically.

Changes description

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Estimated time

Assignee 🍅
@btry 2630
@ajsb85 1
@DIOHz0r 19

References

Closes #N/A
Related #N/A
Depends on #N/A

@btry btry self-assigned this Aug 21, 2018
@DIOHz0r DIOHz0r added this to the 2.1 milestone Aug 21, 2018
DIOHz0r
DIOHz0r reviewed Aug 21, 2018
View reviewed changes
Copy link
Contributor

@DIOHz0r DIOHz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing and you didn't complete pomodoro info

@btry
Copy link
Contributor Author

btry commented Aug 21, 2018 •
edited
Loading

@DIOHz0r
this feature started in october 2017... sorry I don't remember with good accuracy the time needed to do this feature.

@btry btry requested review from DIOHz0r and ajsb85 August 22, 2018 13:21
@btry btry force-pushed the feature/fdroid_2 branch 3 times, most recently from 178121a to 7e44ddc Compare August 22, 2018 13:37
ajsb85
ajsb85 previously approved these changes Aug 22, 2018
View reviewed changes
@ghost
Copy link

ghost commented Aug 22, 2018

There were the following issues with this Pull Request

  • Commit: 575a7d2
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

accesslint[bot]
accesslint bot suggested changes Aug 22, 2018
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

tests/suite-unit/PluginFlyvemdmPackage.php

$instance = $this->newTestedInstance();
$output = $instance::getSpecificValueToDisplay('icon', ['icon' => $png]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing an alt attribute here. This is a problem for people using screen readers. Here are some tips for what to write.

@ghost
Copy link

ghost commented Aug 22, 2018

There were the following issues with this Pull Request

  • Commit: f26134b
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@btry btry changed the title Fdroid market WIP Fdroid market Aug 22, 2018
@btry
Copy link
Contributor Author

btry commented Aug 22, 2018

I solved all merge conflicts which will occur with release/2.0.0, except one. We must wait the merge of the release branch, then rebase this one, solve the conflict, then merge into develop.

Checking the build remains greek for now.

@btry btry mentioned this pull request Aug 22, 2018
Closed
@ghost
Copy link

ghost commented Aug 22, 2018

There were the following issues with this Pull Request

  • Commit: bb33099
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 23, 2018

There were the following issues with this Pull Request

  • Commit: 771d03e
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ajsb85 ajsb85 added the feature label Aug 23, 2018
@ghost
Copy link

ghost commented Aug 24, 2018

There were the following issues with this Pull Request

  • Commit: f306c37
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@btry btry force-pushed the feature/fdroid_2 branch 2 times, most recently from e01ee68 to 794e277 Compare September 4, 2018 20:24
ajsb85
ajsb85 previously approved these changes Sep 5, 2018
View reviewed changes
btry and others added 9 commits September 25, 2018 18:01
@btry @DIOHz0r
test: add tests
e233bf1 
Signed-off-by: Thierry Bugier <[email protected]>
@btry @DIOHz0r
fix: search options update
f468eea 
Signed-off-by: Thierry Bugier <[email protected]>
@btry @DIOHz0r
fix(fdroidmarket): ignore update of markets wihout any URL
0492d7c 
Signed-off-by: Thierry Bugier <[email protected]>
@btry @DIOHz0r
test(fdroidmarket): give debug info if test fails
dd4cc9a 
Signed-off-by: Thierry Bugier <[email protected]>
@btry @DIOHz0r
test(fdroidmarket): fix deletion of apps on update
886c9a0 
Signed-off-by: Thierry Bugier <[email protected]>
@DIOHz0r
build(composer): add SimpleXML extension as required vendors
6682ed0 
Signed-off-by: Domingo Oropeza <[email protected]>
@DIOHz0r
docs(tests): add missing tags for tests
e20cb6e 
Signed-off-by: Domingo Oropeza <[email protected]>
@DIOHz0r
test(fdroid): add asserts for returned value on repository update
983a211 
Signed-off-by: Domingo Oropeza <[email protected]>
@DIOHz0r
test(fdroid): fix test for market on Windows
4cf0db4 
Signed-off-by: Domingo Oropeza <[email protected]>
@DIOHz0r
Copy link
Contributor

DIOHz0r commented Sep 25, 2018

Hello, I did a rebase here for fixing the conflicts.

DIOHz0r
DIOHz0r previously approved these changes Sep 25, 2018
View reviewed changes
@btry
Copy link
Contributor Author

btry commented Sep 26, 2018

I still need to validate that updates of apps in fdroid propagate automatically to devices when needed

@ajsb85 ajsb85 closed this Dec 18, 2018
@ajsb85 ajsb85 reopened this Dec 18, 2018
@ajsb85 ajsb85 changed the base branch from develop to features/for_later December 18, 2018 00:17
@btry btry closed this Dec 20, 2018
@btry btry changed the base branch from features/for_later to develop December 20, 2018 17:41
@btry btry reopened this Dec 20, 2018
@ajsb85 ajsb85 assigned DIOHz0r and unassigned btry Dec 21, 2018
@ajsb85 ajsb85 modified the milestones: 2.1, 3.0 Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@accesslint accesslint[bot] accesslint[bot] requested changes

@DIOHz0r DIOHz0r DIOHz0r left review comments

@Naylin15 Naylin15 Awaiting requested review from Naylin15

@ajsb85 ajsb85 Awaiting requested review from ajsb85

Assignees

@DIOHz0r DIOHz0r

Labels
feature
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@btry @DIOHz0r @ajsb85