This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 79
WIP Flashlight policy #662
Open
DIOHz0r
wants to merge
1
commit into
flyve-mdm:develop
Choose a base branch
from
DIOHz0r:feature/647_flashlight_policy
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
reviewed
Jul 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont cet the point of this policy. Do you really want to enable flashlight with a policy ?
Would not be nord useful to allow / forbid thé use of the flashlight by the user ?
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/647_flashlight_policy
branch
from
August 21, 2018 15:22
6f6452f
to
f36de41
Compare
btry
suggested changes
Oct 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
This policy is irrelevant. We shall not force to turn on or off the flashlight. We should allow or forbid the user do turn it on.
Change the name and the description of the policy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Domingo Oropeza [email protected]
Changes description
Add the option to turn on or off the device flashlight
Checklist
Please check if your PR fulfills the following specifications:
Estimated time
References
Closes #647