Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

WIP Flashlight policy #662

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DIOHz0r
Copy link
Contributor

@DIOHz0r DIOHz0r commented Jul 25, 2018

Signed-off-by: Domingo Oropeza [email protected]

Changes description

Add the option to turn on or off the device flashlight

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Estimated time

Assignee 🍅
@DIOHz0r 2

References

Closes #647

@DIOHz0r DIOHz0r added this to the 2.1 milestone Jul 25, 2018
@DIOHz0r DIOHz0r self-assigned this Jul 25, 2018
@DIOHz0r DIOHz0r requested a review from btry July 25, 2018 14:54
accesslint[bot]
accesslint bot previously approved these changes Jul 25, 2018
Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont cet the point of this policy. Do you really want to enable flashlight with a policy ?

Would not be nord useful to allow / forbid thé use of the flashlight by the user ?

Signed-off-by: Domingo Oropeza <[email protected]>
Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

This policy is irrelevant. We shall not force to turn on or off the flashlight. We should allow or forbid the user do turn it on.

Change the name and the description of the policy.

@ajsb85 ajsb85 closed this Dec 18, 2018
@ajsb85 ajsb85 reopened this Dec 18, 2018
@ajsb85 ajsb85 changed the base branch from develop to features/for_later December 18, 2018 00:19
@btry btry closed this Dec 20, 2018
@btry btry changed the base branch from features/for_later to develop December 20, 2018 17:41
@btry btry reopened this Dec 20, 2018
@ajsb85 ajsb85 assigned DIOHz0r and unassigned DIOHz0r Dec 21, 2018
@ajsb85 ajsb85 modified the milestones: 2.1, 3.0 Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flashlight control policy
3 participants