This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
WIP Add APN policy #550
Open
WIP Add APN policy #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
Hi Looks good. Maybe we can improve the ui by showing all values in a 4 columns table (until twig becomes available in GLPI ;)). Also we should find a better name for apn_apn. |
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
2 times, most recently
from
d61f3a9
to
2c3eec4
Compare
|
I've updated the code based on your comments new UI: |
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
2 times, most recently
from
2b175c4
to
61d6697
Compare
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
2 times, most recently
from
7e620f3
to
4e1a941
Compare
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
from
4e1a941
to
5831ae3
Compare
| $dropdowns = ['apn_auth_type', 'apn_type']; | ||
| foreach ($dropdowns as $inputName) { | ||
| $matches = null; | ||
| preg_match('/.*<select[^>]*name=\'value\[' . $inputName . '\]\'[^>]*>.*/', |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.
Signed-off-by: Domingo Oropeza <[email protected]>
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
from
5831ae3
to
48f6c59
Compare
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/404_apn_policy
branch
from
48f6c59
to
188510d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
Add APN policy task to backend
Checklist
Please check if your PR fulfills the following specifications:
References
Closes #404