This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
WIP Disable notifications policy #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
from
63299e3
to
6bdce32
Compare
ajsb85
previously approved these changes
Apr 21, 2018
ajsb85
reviewed
Apr 21, 2018
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
2 times, most recently
from
321b07c
to
999fbc4
Compare
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
3 times, most recently
from
0db6470
to
351d77b
Compare
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
2 times, most recently
from
8f9099c
to
6f04940
Compare
|
@rafaelje, does this policy has been implemented on the current agent version?. I think this is a 2.1 plugin milestone and not 2.0 |
|
@DIOHz0r Also, this string areNotificationsEnabled is not uniform with other policies. I think disableNotifications is better for consistency with other policies. Can we also split this policy into several policies for different notification types ? |
|
As far as I know there is no more options for notifications right now, could you confirm that @rafaelje ? |
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
2 times, most recently
from
ba3b040
to
4c1c443
Compare
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
from
4c1c443
to
b69d626
Compare
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
from
b69d626
to
205e73f
Compare
|
ping @rafaelje |
|
This policy is not implemented on the agent yet is for 2.1 |
|
@DIOHz0r please change the symbol of this policy, look at my old comments |
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/405_disable_notifications
branch
from
205e73f
to
75a2bde
Compare
btry
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Domingo Oropeza [email protected]
Changes description
Added the policy for disable all notifications on device
Checklist
Please check if your PR fulfills the following specifications:
References
Closes #405
Depends #https://github.com/flyve-mdm/android-mdm-agent/issues/371