proof of concept refactor of FlyteRemote._version_from_hash (todo: needs tests, linting) #2688
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-rliu
changed the title
ddl-rliu
commented
Aug 16, 2024
Comment on lines
942
to
946
| def _version_from_hash( | ||
| md5_bytes: bytes, | ||
| serialization_settings: SerializationSettings, | ||
| default_inputs: typing.Optional[Dict[str, typing.Any]] = None, | ||
| *additional_context: str, | ||
| entity: typing.Union[PythonAutoContainerTask, WorkflowBase], | ||
| ) -> str: |
There was a problem hiding this comment.
A plugin can implement a subclass of FlyteRemote which overrides _version_from_hash to control the version hash calculation (idea from here)
A concern with this idea is that if future PRs modify the behavior of FlyteRemote._version_from_hash, it may become out-of-sync with the custom subclass of FlyteRemote. On the other hand, such an occurrence may be very rare in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link