Fix PDFAsImage scaling and uses of FSImage.scale for immutability changes #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Wow! Thank you. My bad.
I had to annotate scale method with @CheckReturnValue and double-check all usages.
@JamesScrase-PortSwigger FlyingSaucer 9.11.0 has been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2ce6f9f#diff-d210bc82c50b9ada2d6d90ecc8bb3688eaa4df211c1dd891615590558b732759R65 seems to have broken scaling of
<img>tags which reference.pdffiles -ITextReplacedElementFactorywasn't updated to use the new return value.This PR updates the remaining usages of
FSImage.scaleto use the returnedFSImageinstead of the existing object, and passes through the unscaled width and height to the newPDFAsImageinPDFAsImage.scale.