Skip to content

Commit

Permalink
fix proofreading warnings in comments (mostly suggested by Intellij I…
Browse files Browse the repository at this point in the history
…DEA)
  • Loading branch information
asolntsev committed Sep 16, 2023
1 parent 32d7015 commit d7b7f31
Show file tree
Hide file tree
Showing 154 changed files with 329 additions and 335 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Other notable entry points include:
## CONTACT

See the [discussion group](https://groups.google.com/g/flying-saucer-users) for
on-going discussions.
ongoing discussions.


## PROJECT STATUS
Expand All @@ -72,7 +72,7 @@ Excerpt from the latest [merge/release policy](https://groups.google.com/forum/#
>
> The basic contract is this: If you're still using Flying Saucer, need something changed, and are willing to do the work yourself, the change will be accepted and released.
>
> Along that line, please also let me know if you need a release done right away. Otherwise I'll bundle up the changes and do a release every four to six months as long as it's required.
> Along that line, please also let me know if you need a release done right away. Otherwise, I'll bundle up the changes and do a release every four to six months as long as it's required.
This is also the reason why Issues are currently deactivated on GitHub.

Expand Down
8 changes: 4 additions & 4 deletions archive/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@
Revision 1.72 2004/11/16 14:37:48 pdoubleya
Added support for JUnit tests.
Renamed test- targets to test. to be like other names.
Renamed "test-*" targets to "test". to be like other names.
Revision 1.71 2004/11/15 13:41:02 pdoubleya
Renamed javadoc target to _javadoc, as it is meant for internal use; use 'docs' target to generate javadocs for the project.
Expand Down Expand Up @@ -432,7 +432,7 @@
Revision 1.66 2004/11/07 23:24:18 joshy
added menu item to generate diffs
added diffs for multi-colored borders and inline borders
added diffs for multicolored borders and inline borders
Issue number:
Obtained from:
Expand Down Expand Up @@ -600,7 +600,7 @@
removed some extraneous files
update the home page to point to the new jnlp files
updated the resource loader to use the marker class
updated the text of the about box
updated the text of the "about" box
Issue number:
Obtained from:
Expand Down Expand Up @@ -666,6 +666,6 @@
Moved default property settings into build file itself. Now looks for build.properties as override, and a local properties file in userhome/.flyingsaucer/flyingsaucer.build.properties.
Revision 1.39 2004/10/13 22:55:36 pdoubleya
Added system property to auto-load configuration for logging system.
Added system property to autoload configuration for logging system.
-->
8 changes: 4 additions & 4 deletions archive/buildn.xml
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ Exclude abstract FSCssTestCase from junit test suite.
Revision 1.72 2004/11/16 14:37:48 pdoubleya
Added support for JUnit tests.
Renamed test- targets to test. to be like other names.
Renamed "test-*" targets to "test". to be like other names.
Revision 1.71 2004/11/15 13:41:02 pdoubleya
Renamed javadoc target to _javadoc, as it is meant for internal use; use 'docs' target to generate javadocs for the project.
Expand Down Expand Up @@ -408,7 +408,7 @@ Reviewed by:
Revision 1.66 2004/11/07 23:24:18 joshy
added menu item to generate diffs
added diffs for multi-colored borders and inline borders
added diffs for multicolored borders and inline borders
Issue number:
Obtained from:
Expand Down Expand Up @@ -576,7 +576,7 @@ updated the build file
removed some extraneous files
update the home page to point to the new jnlp files
updated the resource loader to use the marker class
updated the text of the about box
updated the text of the "about" box
Issue number:
Obtained from:
Expand Down Expand Up @@ -642,6 +642,6 @@ Revision 1.40 2004/10/18 10:08:19 pdoubleya
Moved default property settings into build file itself. Now looks for build.properties as override, and a local properties file in userhome/.flyingsaucer/flyingsaucer.build.properties.
Revision 1.39 2004/10/13 22:55:36 pdoubleya
Added system property to auto-load configuration for logging system.
Added system property to autoload configuration for logging system.
-->
2 changes: 1 addition & 1 deletion archive/etc/build/docs.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<project name="build.docs">
<!--
DONT USE THIS FROM COMMAND LINE; use docs
DON'T USE THIS FROM COMMAND LINE; use docs
builds JavaDoc for all code. Meant to be used with antcall; set parameters
for properties antcall.dest.javadoc.dir and antcall.javadoc.file
-->
Expand Down
6 changes: 3 additions & 3 deletions archive/etc/build/tests.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
</java>
</target>

<!-- Runs a speed test after a compile -->
<!-- Runs a speed test after "compile" -->
<target name="test.speed" depends="test.css-speed"></target>

<!-- Runs a speed test after a compile -->
<!-- Runs a speed test after "compile" -->
<target name="test.css-speed" depends="compile" description="Test timing on loading Hamlet.xhtml multiple times.">
<java classname="org.xhtmlrenderer.test.HamletSpeedTest"
fork="${java-exec.fork.tests}">
Expand All @@ -44,7 +44,7 @@
</java>
</target>

<!-- Runs a custom block test after a compile -->
<!-- Runs a custom block test after "compile" -->
<target name="test.customblock" depends="compile">
<java classname="org.xhtmlrenderer.test.CustomBlockTest"
classpath="${dest.java.dir}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ protected Font resolveFont(SharedContext ctx, String font, float size, IdentValu
// now that we have a root font, we need to create the correct version of it
Font fnt = createFont(ctx, root_font, size, weight, style, variant);

// add the font to the hash so we don't have to do this again
// add the font to the hash, so we don't have to do this again
instance_hash.put(font_instance_name, fnt);
return fnt;
}
Expand Down Expand Up @@ -334,7 +334,7 @@ public FSFont resolveFont(SharedContext renderingContext, FontSpecification spec
*
* Revision 1.3 2004/10/23 13:03:45 pdoubleya
* Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc)
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc.)
* Added CVS log comments at bottom.
*
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public String calculate(RenderingContext c, FSFunction function, InlineText text
}

// Compute value width using 100x string to get more precise width.
// Otherwise there might be a small gap at the right side. This is
// Otherwise, there might be a small gap on the right side. This is
// necessary because a TextRenderer usually use double/float for width.
StringBuffer tmp = new StringBuffer(100 * value.length());
for (int i = 0; i < 100; i++) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public void setSupportCMYKColors(boolean b) {
* Inline backgrounds now work correctly, as does mixing of inlines and blocks for style inheritance
*
* Revision 1.28 2005/05/08 15:37:29 tobega
* Fixed up style caching so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
* Fixed up style caching, so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
*
* Revision 1.27 2005/05/08 14:51:22 tobega
* Removed the need for the Styler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,7 @@ public CSSSideProperties(CSSName top, CSSName right, CSSName bottom, CSSName lef
* Fixed id assignment to scope primitive names to start of list, in static block.
*
* Revision 1.11 2005/06/21 08:23:13 pdoubleya
* Added specific list and count of primitive, non shorthand properties, and CalculatedStyle now sizes array to this size.
* Added specific list and count of primitive, non-shorthand properties, and CalculatedStyle now sizes array to this size.
*
* Revision 1.10 2005/06/19 23:02:37 tobega
* Implemented calculation of minimum cell-widths.
Expand Down Expand Up @@ -2024,7 +2024,7 @@ public CSSSideProperties(CSSName top, CSSName right, CSSName bottom, CSSName lef
* Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards
* except for common packages
* (java.io, java.util, etc).
* (java.io, java.util, etc.).
* Added CVS log comments at bottom.
*
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ public boolean isDependentOnFontSize() {
* Added missing idents for cursor and font-size, removed useless comments to make sorting easier.
*
* Revision 1.20 2006/05/08 21:24:24 pdoubleya
* Log, don't throw exception, if we check for an absolute unit but it doesn't make sense to do so (IdentValue.hasAbsoluteUnit()).
* Log, don't throw exception, if we check for an absolute unit, but it doesn't make sense to do so (IdentValue.hasAbsoluteUnit()).
*
* Revision 1.19 2005/12/28 00:50:51 peterbrant
* Continue ripping out first try at pagination / Minor method name refactoring
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public static boolean looksLikeANumber(String val) {

/**
* Given a String, returns either the rgb declaration for the color, or the
* hex declaration; used to cleanup assignments like "red" or "green".
* hex declaration; used to clean up assignments like "red" or "green".
*
* @param value A String which contains a Color identifier, an rgb
* assignment or a Color hex value.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public static String getCssValueTypeDesc(CSSValue cssValue) {
*/
public static boolean isNumber(short cssPrimitiveType) {
switch (cssPrimitiveType) {
// fall thru on all these
// fall through on all these
// relative length or size
case CSSPrimitiveValue.CSS_EMS:
case CSSPrimitiveValue.CSS_EXS:
Expand Down Expand Up @@ -386,7 +386,7 @@ public static short guessType(String value) {
* Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards
* except for common packages
* (java.io, java.util, etc).
* (java.io, java.util, etc.).
* Added CVS log comments at bottom.
*
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class CascadedStyle {
private String fingerprint;

/**
* Creates a <code>CascadedStyle</code>, setting the display property to
* Creates a <code>CascadedStyle</code>, setting the display property
* to the value of the <code>display</code> parameter.
*/
public static CascadedStyle createAnonymousStyle(IdentValue display) {
Expand Down Expand Up @@ -285,7 +285,7 @@ public String getFingerprint() {
* Fixe inline border mismatch and started on styling problem in switching between blocks and inlines
*
* Revision 1.9 2005/05/08 15:37:26 tobega
* Fixed up style caching so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
* Fixed up style caching, so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
*
* Revision 1.8 2005/05/08 13:02:36 tobega
* Fixed a bug whereby styles could get lost for inline elements, notably if root element was inline. Did a few other things which probably has no importance at this moment, e.g. refactored out some unused stuff.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public List buildDeclarations(
CSSName.LINE_HEIGHT, new PropertyValue(IdentValue.NORMAL), important, origin);
}

// XXX font-family should be reset too (although does this really make sense?)
// XXX font-family should be reset too (although, does this really make sense?)

result = new ArrayList(ALL.length);
result.add(fontStyle);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ public List buildDeclarations(
// Both Opera and Firefox parse "Century Gothic" Arial sans-serif as
// [Century Gothic], [Arial sans-serif] (i.e. the comma is assumed
// after a string). Seems wrong per the spec, but FF (at least)
// does it in standards mode so we do too.
// does it in standards mode, so we do too.
List consecutiveIdents = new ArrayList();
List normalized = new ArrayList(values.size());
for (Iterator i = values.iterator(); i.hasNext(); ) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ public String getFingerprint() {
* sequence number returned from this method would take priority in the
* cascade, so that a user important! property would override a user
* non-important! property, and so on. The actual integer value returned by
* this method is unimportant, but has a lowest value of 0 and increments
* sequentially by 1 for each increase in origin/importance..
* this method is unimportant, but has the lowest value of 0 and increments
* sequentially by 1 for each increase in origin/importance.
*
* @return See method javadoc.
*/
Expand Down Expand Up @@ -261,7 +261,7 @@ public int getOrigin() {
* Allow for custom properties (don't break).
*
* Revision 1.13 2005/05/08 15:37:27 tobega
* Fixed up style caching so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
* Fixed up style caching, so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
*
* Revision 1.12 2005/01/29 20:19:21 pdoubleya
* Clean/reformat code. Removed commented blocks, checked copyright.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
public class StylesheetInfo {

/** Description of the Field */
private Stylesheet stylesheet = null;//just to be able to attach "dummy" stylesheets. Also might save a lookup if it's already looked up
private Stylesheet stylesheet = null;//just to be able to attach "dummy" stylesheets. Also, might save a lookup if it's already looked up
/** Description of the Field */
private String title;
/** Description of the Field */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1259,7 +1259,7 @@ public boolean isCanBeShrunkToFit() {
*
* $Log$
* Revision 1.110 2010/01/12 14:33:27 peterbrant
* Ignore auto margins when calculating table min/max width. Also, when deciding whether or not to proceed with the auto margin calculation for a table, make sure we compare consistently with how the table min width is actually set.
* Ignore auto margins when calculating table min/max width. Also, when deciding whether to proceed with the auto margin calculation for a table, make sure we compare consistently with how the table min width is actually set.
*
* Revision 1.109 2009/11/08 23:52:48 peterbrant
* Treat percentage widths as auto when calculating min/max widths
Expand All @@ -1286,7 +1286,7 @@ public boolean isCanBeShrunkToFit() {
* Implement CMYK color support for PDF output, starting with patch from Mykola Gurov / Banish java.awt.Color from FS core layout classes
*
* Revision 1.101 2008/07/14 11:12:37 peterbrant
* Fix two bugs when -fs-table-paginate is paginate. Block boxes in cells in a <thead> that were also early on the page could be positioned incorrectly. Line boxes contained within inline-block or inline-table content in a paginated table were generally placed incorrectly.
* Fix two bugs when -fs-table-paginate is paginated. Block boxes in cells in a <thead> that were also early on the page could be positioned incorrectly. Line boxes contained within inline-block or inline-table content in a paginated table were generally placed incorrectly.
*
* Revision 1.100 2007/08/29 22:18:19 peterbrant
* Experiment with text justification
Expand Down Expand Up @@ -1406,7 +1406,7 @@ public boolean isCanBeShrunkToFit() {
* Return value from abs value check never assigned!
*
* Revision 1.66 2006/05/08 21:24:24 pdoubleya
* Log, don't throw exception, if we check for an absolute unit but it doesn't make sense to do so (IdentValue.hasAbsoluteUnit()).
* Log, don't throw exception, if we check for an absolute unit, but it doesn't make sense to do so (IdentValue.hasAbsoluteUnit()).
*
* Revision 1.65 2006/05/08 20:56:09 pdoubleya
* Clean exception handling for case where assigned property value is not understood as a valid value; use initial value instead.
Expand Down Expand Up @@ -1526,7 +1526,7 @@ public boolean isCanBeShrunkToFit() {
* Refactored the css package to allow a clean separation from the core.
*
* Revision 1.26 2005/06/21 08:23:13 pdoubleya
* Added specific list and count of primitive, non shorthand properties, and CalculatedStyle now sizes array to this size.
* Added specific list and count of primitive, non-shorthand properties, and CalculatedStyle now sizes array to this size.
*
* Revision 1.25 2005/06/16 07:24:46 tobega
* Fixed background image bug.
Expand All @@ -1553,7 +1553,7 @@ public boolean isCanBeShrunkToFit() {
* Caching fonts in CalculatedStyle
*
* Revision 1.19 2005/05/08 15:37:28 tobega
* Fixed up style caching so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
* Fixed up style caching, so it really works (internalize CascadedStyles and let each CalculatedStyle keep track of its derived children)
*
* Revision 1.18 2005/05/08 14:51:21 tobega
* Removed the need for the Styler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static Color rgbToColor( RGBColor rgbcol ) {
*
* Revision 1.2 2004/10/23 13:30:42 pdoubleya
* Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc).
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc.).
* Added CVS log comments at bottom.
*
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public interface DocumentListener {
*
* Revision 1.2 2004/10/23 13:37:29 pdoubleya Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards except for common packages (java.io,
* java.util, etc). Added CVS log comments at bottom.
* java.util, etc.). Added CVS log comments at bottom.
*
*
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public interface NamespaceHandler {
boolean isImageElement(Element e);

/**
* Determines whether or not the specified Element represents a
* Determines whether the specified Element represents a
* &lt;form&gt;.
*
* @param e The Element to evaluate.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ public FSFontMetrics getFSFontMetrics(
public int getSmoothingLevel();

/**
* @deprecated no-op, will be removed in a future release. Anti-aliasing is now controlled via the smoothing
* threshhold.
* @deprecated no-op, will be removed in a future release. Antialiasing is now controlled via the smoothing
* threshold.
* @param level no-op
*/
public void setSmoothingLevel(int level);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public interface UserAgentCallback {
String getBaseURL();

/**
* Used to find a uri that may be relative to the BaseURL.
* Used to find an uri that may be relative to the BaseURL.
* The returned value will always only be used via methods in the same
* implementation of this interface, therefore may be a private uri-space.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ public void setListIndex(int listIndex) {
* Only do incremental rendering if we are in an interactive context
*
* Revision 1.15 2005/10/02 21:29:58 tobega
* Fixed a lot of concurrency (and other) issues from incremental rendering. Also some house-cleaning.
* Fixed a lot of concurrency (and other) issues from incremental rendering. Also, some house-cleaning.
*
* Revision 1.14 2005/09/29 21:34:02 joshy
* minor updates to a lot of files. pulling in more incremental rendering code.
Expand Down Expand Up @@ -986,7 +986,7 @@ public void setListIndex(int listIndex) {
*
* Revision 1.16 2004/11/09 15:53:48 joshy
* initial support for hover (currently disabled)
* moved justification code into it's own class in a new subpackage for inline
* moved justification code into its own class in a new subpackage for inline
* layout (because it's so blooming complicated)
*
* Issue number:
Expand Down Expand Up @@ -1102,7 +1102,7 @@ public void setListIndex(int listIndex) {
*
* Revision 1.4 2004/10/23 13:46:46 pdoubleya
* Re-formatted using JavaStyle tool.
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc).
* Cleaned imports to resolve wildcards except for common packages (java.io, java.util, etc.).
* Added CVS log comments at bottom.
*
*
Expand Down
Loading

0 comments on commit d7b7f31

Please sign in to comment.