Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PurgePackage raising error when package is not found. #172

Closed
wants to merge 2 commits into from

Conversation

sweh
Copy link
Contributor

@sweh sweh commented May 8, 2024

Current behavior:

110d05e4281: Scheduling component crontab ...
110d05e4281 > Filebeat > PurgePackage('filebeat')
ERROR: nix-env --query filebeat
    Return code: 1
STDOUT

STDERR
error: selector 'filebeat' matches no derivations

110d05e4281 > CronTab > InstallCrontab

Expected behaviour (achieved by this fix):

110d05e4281: Scheduling component crontab ...
110d05e4281 > Filebeat > PurgePackage('filebeat')
Could not find package to purge: filebeat
110d05e4281 > CronTab > InstallCrontab

Current behavior:

```
110d05e4281: Scheduling component crontab ...
110d05e4281 > Filebeat > PurgePackage('filebeat')
ERROR: nix-env --query filebeat
    Return code: 1
STDOUT

STDERR
error: selector 'filebeat' matches no derivations

110d05e4281 > CronTab > InstallCrontab
```

Expected behaviour (achieved by this fix):

```
110d05e4281: Scheduling component crontab ...
110d05e4281 > Filebeat > PurgePackage('filebeat')
Could not find package to purge: filebeat
110d05e4281 > CronTab > InstallCrontab
```
Copy link
Member

@elikoga elikoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR does what is says and looks to change the right thing

@zagy
Copy link
Member

zagy commented May 15, 2024

replaced by #174

@zagy zagy closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants