Pl 132755 refactor module and subcommand structure #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start demonstrating the general workflow using the simplistic file source clean up old setuptools configs
The main goal here is to prepare for S3 backups, which have a fundamentally different structure.
|
Overriding review as this code was originally written by @dhnasa and I'm doing the review. GitHubs little brain can't cope with that, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s): PL-132755, ...
The overall test coverage is a bit worse at the moment and we're likely broken on master. However, we need this as the foundational work for S3 and I'd rather not spend more time gold-plating something we don't yet know 100% we're going to use it in this shape or need to improve the shape further anyways.
Security implications
We are calling more sub-commands now, so that needs to be managed, but that's part of deploying it and normally handled with NixOS tools.
Nothing specific to test.