Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put resources in home directory #121

Merged
merged 8 commits into from
Oct 2, 2024
Merged

fix: put resources in home directory #121

merged 8 commits into from
Oct 2, 2024

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Sep 30, 2024

Fixes #119

Avoid purging of resources on simbridge updates by moving them to an external location.

Separate PR:

  • fix terrain map being downloaded every update, probably a separate PR, ideas exist

@Saschl Saschl changed the base branch from main to feature/terronnd_a380 September 30, 2024 08:33
apps/server/src/terrain.ts Outdated Show resolved Hide resolved
Copy link
Member

@alepouna alepouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments otherwise LGTM

apps/server/src/terrain.ts Outdated Show resolved Hide resolved
import * as path from 'path';

// @ts-expect-error I don't know why
export const getSimbridgeDir = () => (path.join(homedir() + '/flybywire-externaltools-simbridge'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Saschl Saschl marked this pull request as ready for review September 30, 2024 19:03
@Saschl Saschl changed the base branch from feature/terronnd_a380 to main September 30, 2024 20:05
@Saschl Saschl force-pushed the fix/no-purge-resources branch from 6a456ff to f3a9a3a Compare September 30, 2024 20:09
@Saschl Saschl merged commit ccd1aa0 into main Oct 2, 2024
1 check passed
@Saschl Saschl deleted the fix/no-purge-resources branch October 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating simBridge deletes all resources files
4 participants