Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(A380X/MFD): Fixed the crossing climb/descent speed limit pseudo-waypoint label on the A380X #9738

Conversation

bulenteroglu
Copy link
Contributor

@bulenteroglu bulenteroglu commented Jan 9, 2025

Summary of Changes

  • Add LIM_PSEUDO_WPT_LABEL to AircraftConfig.VnavConfig

  • Depending on the aircraft type, use the correct ident for the pseudo-waypoint that mark where the aircraft crosses climb/descent speed limit altitudes

Screenshots (if necessary)

Climb A380
Screenshot 2025-01-09 202102
Descent A380
Screenshot 2025-01-09 202109
Climb A320
Screenshot 2025-01-09 203942
Descent A320
Screenshot 2025-01-09 204051

References

image

Additional context

Discord username (if different from GitHub): senolitam

Testing instructions

Enter a full flight plan with INIT-B completed to have predictions. Then check the crossing/descending climb speed pseudo waypoint in the MCDU/MFD.

Test in both aircrafts (A320 & A380)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@bulenteroglu bulenteroglu changed the title fix:add condition to check if a380 to pick correct ident fix: add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt Jan 9, 2025
@bulenteroglu bulenteroglu changed the title fix: add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt fix(a380x/mfd): add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt Jan 9, 2025
@bulenteroglu bulenteroglu marked this pull request as ready for review January 9, 2025 22:28
@bulenteroglu bulenteroglu changed the title fix(a380x/mfd): add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt fix(A380X/MFD): Fixed the crossing climb/descent speed limit pseudo-waypoint label on the A380X Jan 9, 2025
@BravoMike99 BravoMike99 added QA Tier 1 QA Ready to Test A380X Related to the A380X aircraft labels Jan 12, 2025
@nebj00la
Copy link

Quality Assurance Trainee Report

Discord Username : nebj00la
Object of testing : #9738
Aircraft : A380X
Tier of Testing : 1
Date : 23/01/2025

Testing Process:

  1. Entered a full flight plan with INIT-B completed. Checked the crossing/descending climb speed pseudo waypoint in the MCDU/MFD for borth A380 and A320.
  2. Expected results were seen.

Testing Results:
Passed

Media:
9738-380
9738-320

@BravoMike99 BravoMike99 merged commit 78ef3c9 into flybywiresim:master Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants