Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/takeoff calculator): Accuracy update for takeoff calculator V2 speeds #9733

Merged
merged 18 commits into from
Jan 17, 2025

Conversation

donstim
Copy link
Contributor

@donstim donstim commented Jan 8, 2025

Fixes #[issue_no]

Summary of Changes

Changes to some of the V2 speed parameters for all flap configurations. This PR supersedes #9139.

Screenshots (if necessary)

This PR was initiated to address an issue brought up in the Discord QA channel regarding a takeoff calculation for LFBO (Toulouse/Blagnac airport). A screenshot of this original calculation is shown below:
LFBO 32L 63 349 T CONF 1+F Old A32NX
The IRL FlySmart calculation is shown here:
LFBO 32L 63 3 T CONF 1+F
After merging of this PR, the A32NX takeoff calculation will show:
Screenshot 2025-01-14 173053
Still not perfect, but much better. Making changes for better matches with the data always must be balanced with how they affect accuracy for other calculations. (Note: Small differences in some of the runway parameters were made to match the FlySmart calculation, but do not really change the conclusion.)

In PR #9139 , changes were proposed to provide a better match for some specific calculations at EDDB. A screenshot of the old calculation is shown below:
EDDB 06R 1+F A32NX calc
Here is the IRL FlySmart calculation:
EDDB 06R 1+F FlySmart calc
And here is the A32NX calculation after this PR is merged:
Screenshot 2025-01-14 125846

A more complete comparison of the A32NX takeoff calculator to the IRL FlySmart calculator and the SimBrief takeoff calculator is shown in the attached file for a large number of example cases.
Takeoff Calculator Comparisons - IRL, A32NX, SimBrief.pdf

References

Additional context

Discord username (if different from GitHub):

Testing instructions

There are no coding changes in this PR, only changes to some constants used in the calculations, so it should not create any issues for the airplane. Feel free to give it a whirl and so a couple of calcs to verify I guess.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@Benjozork Benjozork changed the title fix(a32nx/takeoff calculator: Minor fix for issue identified in other QA testing fix(a32nx/takeoff calculator): Minor fix for issue identified in other QA testing Jan 8, 2025
@Benjozork
Copy link
Member

Please add testing instructions

@Benjozork Benjozork added Waiting For Response This issue or PR needs a response from the author EFB A32NX Related to the A32NX aircraft labels Jan 8, 2025
@donstim
Copy link
Contributor Author

donstim commented Jan 8, 2025

Thanks for approving. I'll add them when it's ready for testing. It was supposed to be a draft, not ready for QA yet.

@donstim donstim marked this pull request as draft January 8, 2025 05:49
@donstim donstim marked this pull request as ready for review January 9, 2025 23:39
@donstim donstim marked this pull request as draft January 10, 2025 00:09
@donstim donstim marked this pull request as ready for review January 10, 2025 04:17
@donstim donstim marked this pull request as draft January 10, 2025 05:14
@donstim donstim marked this pull request as ready for review January 10, 2025 06:21
@donstim donstim marked this pull request as draft January 10, 2025 06:59
@donstim donstim marked this pull request as ready for review January 11, 2025 04:48
@donstim donstim marked this pull request as draft January 11, 2025 05:19
@donstim donstim marked this pull request as ready for review January 12, 2025 07:01
@donstim donstim marked this pull request as draft January 12, 2025 07:32
@donstim donstim marked this pull request as ready for review January 14, 2025 19:33
@donstim donstim marked this pull request as draft January 14, 2025 19:51
@donstim donstim marked this pull request as ready for review January 14, 2025 19:51
@donstim donstim marked this pull request as draft January 14, 2025 20:34
@donstim donstim marked this pull request as ready for review January 15, 2025 01:53
@donstim donstim removed the Waiting For Response This issue or PR needs a response from the author label Jan 15, 2025
@donstim donstim changed the title fix(a32nx/takeoff calculator): Minor fix for issue identified in other QA testing fix(a32nx/takeoff calculator): Accuracy update for takeoff calculator V2 speeds Jan 16, 2025
@tracernz
Copy link
Member

Dev Team QA Report

Discord Username : tracernz
Object of testing : #9733
Aircraft : A32NX
Tier of Testing : 1
Date : 17/1/2025

Testing Process:
Tested a variety of takeoff scenarios on runways I am familiar with. All got expected results.
Confirmed the same results as the PR description.

Testing Results:
Passed

@tracernz tracernz enabled auto-merge (squash) January 17, 2025 07:51
@tracernz tracernz merged commit bf00fa8 into flybywiresim:master Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft EFB QA Passed
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants