-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/fctl): Protection speeds improvements after flight model update #9694
Open
flogross89
wants to merge
11
commits into
flybywiresim:master
Choose a base branch
from
flogross89:fix-a380x-fac-alpha-after-don
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(a380x/fctl): Protection speeds improvements after flight model update #9694
flogross89
wants to merge
11
commits into
flybywiresim:master
from
flogross89:fix-a380x-fac-alpha-after-don
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
force-pushed
the
fix-a380x-fac-alpha-after-don
branch
from
January 2, 2025 04:07
2c3ace7
to
287cd2e
Compare
flogross89
force-pushed
the
fix-a380x-fac-alpha-after-don
branch
from
January 2, 2025 22:38
9062486
to
9583e06
Compare
flogross89
changed the title
fix(a380x/prim): Adapt alpha speeds after flight model update
fix(a380x/fctl): Protection speeds improvements after flight model update
Jan 2, 2025
flogross89
added
QA A380 Only
QA only for A380 required
A380X
Related to the A380X aircraft
labels
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9689
Fixes #8725
Summary of Changes
Screenshots (if necessary)
vs
vs
vs
PFD direct law indications:
References
https://www.youtube.com/watch?v=hDh_9MEz-hg
https://www.youtube.com/watch?v=AI8yFhuEa4Q
https://www.youtube.com/watch?v=pHui34_ODnc
https://www.youtube.com/watch?v=qcXQKQukxkI&t=284s
https://www.youtube.com/watch?v=DtIF26FEZug&t=338s
Additional context
Note for reviewer: Only alpha max and alpha protection look-up tables were modified in the MATLAB models, no MATLAB review needed.
Current alpha tables:
alpha_max:
alpha_prot:
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.