feat: support mouse backward & forward buttons as ShortcutKeys
#1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zefr0x
commented
Aug 23, 2024
| version="1.1" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| xmlns:svg="http://www.w3.org/2000/svg"> | ||
| <!-- TODO: Create an icon for backward mouse button. --> |
There was a problem hiding this comment.
We need an icon for backward mouse shortcut key.
| version="1.1" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| xmlns:svg="http://www.w3.org/2000/svg"> | ||
| <!-- TODO: Create an icon for forward mouse button. --> |
There was a problem hiding this comment.
We need an icon for forward mouse shortcut key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a base for #499 to map the backward and forward mouse buttons to the history (Undo and Redo).
We can hard-map them to history actions, but this will limit mouse buttons configurability, so it's better to wait longer for the implementation of this feature.
I would like to do a follow-up PR for those two new shortcut actions which will also partially do #865, but we need to discuss a refactoring for the UI and the logic behind it since the current settings are designed mainly for pen related actions.