dws: ignore bad jobids in workflows #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: sometimes users create workflows with nonsense jobids. For instance, on Tuolumne recently a user created a workflow with jobid "manual", crashing the service because the jobid could not be converted to a flux job ID. Catch all exceptions that occur while trying to fetch basic data about a workflow and log them, but do not let them crash the service.
Problem: admins using the resource.scheduling table may only want the contents of the 'scheduling' key from JGF. Add an option to only output the 'scheduling' key.
wihobbs
reviewed
Sep 20, 2024
| @@ -418,8 +418,8 @@ def workflow_state_change_cb(event, handle, k8s_api, disable_fluxion): | |||
| workflow = event["object"] | |||
| jobid = int(flux.job.JobID(workflow["spec"]["jobID"])) | |||
There was a problem hiding this comment.
I'm wondering if JobID should provide a .int method when I read this, or maybe .real would work
wihobbs
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: sometimes users create workflows with nonsense jobids. For instance, on Tuolumne recently a user created a workflow with jobid "manual", crashing the service because the jobid could not be converted to a flux job ID.
Catch all exceptions that occur while trying to fetch basic data about a workflow and log them, but do not let them crash the service.
Exception seen: