Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dws: increase timeout of shell plugin #194

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jameshcorbett
Copy link
Member

Problem: as described in issue #192, on large, busy systems with lots of jobs, the dws_environment shell plugin's two-second timeout to fetch the first eventlog entry is too short and occasionally times out.

In Mark Grondona's tests to reproduce the issue, all succeeded within five seconds. However, to be safe, increase the timeout to thirty seconds.

Fixes #192.

Problem: as described in issue flux-framework#192, on large, busy systems with
lots of jobs, the dws_environment shell plugin's two-second timeout
to fetch the first eventlog entry is too short and occasionally
times out.

In Mark Grondona's tests to reproduce the issue, all succeeded
within five seconds. However, to be safe, increase the timeout to
thirty seconds.

Fixes flux-framework#192.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 799d36b into flux-framework:master Aug 8, 2024
8 checks passed
@jameshcorbett jameshcorbett deleted the dws-shell-timeout branch August 8, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to read eventlog in dws_environment shell plugin
2 participants