-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes Core into Core and Client and Exposes Client API to Users #120
Open
ilumsden
wants to merge
17
commits into
flux-framework:main
Choose a base branch
from
TauferLab:exported_core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the top level CMakeLists.txt
…me variable names
…ikely to interfere with users' code
…ad_ctx_init to succeed Adds missing curly brace in top level CMake
ilumsden
force-pushed
the
exported_core
branch
2 times, most recently
from
September 3, 2024 20:42
d2c8a4c
to
bc4735f
Compare
… external library
ilumsden
force-pushed
the
exported_core
branch
from
September 5, 2024 15:06
8206e82
to
57991dd
Compare
ilumsden
changed the title
Makes Core and Ctx available to users
Makes Core into Core and Client and Exposes Client API to Users
Sep 5, 2024
I tested this using A4X, and it works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on feedback from #118. If we like it, it can supersede and replace #118.
This PR moves headers around and modifies the CMake to make DYAD's core and ctx libraries available to users. It also splits
dyad_core.h
anddyad_structures.h
into multiple headers (an external header and an internal one) so that excess function definitions are not exposed to users. It also creates a newdyad/core/dyad.h
header anddyad_client
CMake target to refer to both libraries at once.