Update sanctuary-def and use sanctuary-scripts #19
Conversation
| "padding-line-between-statements": 0 | ||
| "func-call-spacing": ["off"], | ||
| "indent": ["off"], | ||
| "no-unexpected-multiline": ["off"] |
There was a problem hiding this comment.
Disabling these rules allows for sanctuary-js/sanctuary#438 -style code.
| @@ -34,19 +38,14 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "fluture": ">=5.0.0 <9.0.0", | |||
| "sanctuary-def": ">=0.8.0 <0.15.0" | |||
| "sanctuary-def": ">=0.15.0 <0.16.0" | |||
There was a problem hiding this comment.
This is an important piece of diff as it highlights the fact that we've got a breaking change.
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 9 13 +4
Branches 0 1 +1
=====================================
+ Hits 9 13 +4
Continue to review full report at Codecov.
|
Avaq
force-pushed
the
avaq/update-sanctuary-def
branch
from
d31c40d to
e624de0
Compare
| @@ -1,7 +1,8 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "4.0.0" | |||
| - "5" | |||
| - "6.0.0" | |||
| - "6" | |||
There was a problem hiding this comment.
You're specifying both "6" and "6.0.0" because the latter is the oldest version you support?
index.js
Outdated
| //. > $.test | ||
| //. . (env) | ||
| //. . (ConcurrentFutureType ($.String) ($.Number)) | ||
| //. . (Future.Par.of (1)); |
There was a problem hiding this comment.
Nit: I suggest indenting the wrapped lines by two spaces rather than one.
There was a problem hiding this comment.
I've aligned the leading dots (.) with the >. There should be no indentation, right?
There was a problem hiding this comment.
This is what I had in mind:
//. > $.test
- //. . (env)
- //. . (ConcurrentFutureType ($.String) ($.Number))
- //. . (Future.Par.of (1));
+ //. . (env)
+ //. . (ConcurrentFutureType ($.String) ($.Number))
+ //. . (Future.Par.of (1));There was a problem hiding this comment.
Ahhh, now I see! The first space after the second . is not considered indentation! Thanks.
Avaq
force-pushed
the
avaq/update-sanctuary-def
branch
from
e624de0 to
a58ef19
Compare
Closes #18
I started with the sanctuary def update, but ended up redoing pretty much everything. I'll highlight some important lines.