Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wifi-only downloads for iOS #768

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lyio
Copy link
Contributor

@lyio lyio commented Nov 25, 2022

  • Use the correct data type to evaluate the error codes when
    opening the SQLite database.

+ Use the correct data type to evaluate the error codes when
opening the SQLite database.
+ Add a way to migrate the database schema on iOS
+ This partly reverts the changes to the db location
+ Add a column to the table `task`
+ Add the value to the record when modeling tasks
… via cellular data

+ iOS handles this on a session basis and not on a per task basis, so we have
to configure two different sessions. One that allows downloading via cellular
data and one that doesn't.
@lyio lyio changed the title Correctly read the error/success codes Implement wifi-only downloads for iOS Nov 25, 2022
@lyio lyio marked this pull request as draft November 25, 2022 11:49
@lyio
Copy link
Contributor Author

lyio commented Nov 25, 2022

@bartekpacia bartekpacia marked this pull request as ready for review January 29, 2023 19:12
@bartekpacia bartekpacia marked this pull request as draft January 29, 2023 19:12
@lyio
Copy link
Contributor Author

lyio commented Jan 30, 2023

I just saw #793. I will have to revisit this for when that is merged. Makes no sense to merge this at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant