Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Display name for downloading task #764

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

838
Copy link
Contributor

@838 838 commented Nov 23, 2022

Adds a option to give the download a readable display name.

For now only used for notification title in android.

@838
Copy link
Contributor Author

838 commented Dec 21, 2022

@bartekpacia

Will you please take a look at this when you have time before it falls long behind the master with lots of merge conflicts? :)

@bartekpacia
Copy link
Collaborator

Hi @838, thanks for your contribution.

Will you be able to implement the same for iOS? Currently, there's already a lot of Android-specific options and I'd prefer not to make the situation worse.

@838
Copy link
Contributor Author

838 commented Dec 22, 2022

Hi @bartekpacia

That was also my intention to add this feature in ios, so the displayName could be used as title instead of filename for the modal dialog when opening a downloaded file. But I saw there is a Swift migration is going on, and therefore I wanted to wait for that to be complete :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants