Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

Commit

Permalink
chore: v1.0.0 rc.4 (#619)
Browse files Browse the repository at this point in the history
  • Loading branch information
felangel authored May 14, 2021
1 parent 4fb1f43 commit 555d340
Show file tree
Hide file tree
Showing 41 changed files with 787 additions and 263 deletions.
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Bug Report
about: Create a report to help us improve
title: 'fix: '
labels: bug
---

**Description**
A clear and concise description of what the bug is.

**Steps To Reproduce**

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected Behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional Context**
Add any other context about the problem here.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Build System
about: Changes that affect the build system or external dependencies
title: 'build: '
labels: build
---

**Description**

Describe what changes need to be done to the build system and why

**Requirements**

- [ ] The build system is passing
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/chore.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Chore
about: Other changes that don't modify src or test files
title: 'chore: '
labels: chore
---

**Description**

Clearly describe what change is needed and why. If this changes code then please use another issue type.

**Requirements**

- [ ] No functional changes to the code
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/ci.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Continuous Integration
about: Changes to the CI configuration files and scripts
title: 'ci: '
labels: ci
---

**Description**

Describe what changes need to be done to the ci/cd system and why

**Requirements**

- [ ] The ci system is passing
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blank_issues_enabled: false
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/documentation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Documentation
about: Improve the documentation so all collaborators have a common understanding
title: 'docs: '
labels: documentation
---

**Description**

Clearly describe what documentation you are looking to add or improve.

**Requirements**

- [ ] Checklist of requirements to be fulfilled
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: Feature Request
about: A new feature to be added to the project
title: 'feat: '
labels: feature
---

**Description**

Clearly describe what you are looking to add. The more business/user context the better.

**Requirements**

- [ ] Checklist of requirements to be fulfilled

**Additional Context**

Add any other context or screenshots about the feature request go here.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/performance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Performance Update
about: A code change that improves performance
title: 'perf: '
labels: performance
---

**Description**

Clearly describe what code needs to be changed and what the performance impact is going to be. Bonus point's if you can tie this directly to user experience.

**Requirements**

- [ ] There is no drop in the unit or widget test coverage percentage.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/refactor.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Refactor
about: A code change that neither fixes a bug nor adds a feature
title: 'refactor: '
labels: refactor
---

**Description**

Clearly describe what needs to be refactored any why. Please provide links to related issues (bugs or upcoming features) in order to help prioritize.

**Requirements**

- [ ] There is no drop in the unit or widget test coverage percentage.
16 changes: 16 additions & 0 deletions .github/ISSUE_TEMPLATE/revert.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
name: Revert Commit
about: Reverts a previous commit
title: 'revert: '
labels: revert
---

**Description**

Provide a link to a PR/Commit that you are looking to revert and why.

**Requirements**

- [ ] Change has been reverted
- [ ] No change in unit/widget test coverage has happened
- [ ] A new ticket is created for any follow on work that needs to happen
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/style.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Style Changes
about: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
title: 'style: '
labels: style
---

**Description**

Clearly describe what you are looking to change and why.

**Requirements**

- [ ] There is no drop in the unit or widget test coverage percentage.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/test.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Test
about: Adding missing tests or correcting existing tests
title: 'test: '
labels: test
---

**Description**

List out the tests that need to be added or changed. Please also include any information as to why this was not covered in the past.

**Requirements**

- [ ] There is no drop in the unit or widget test coverage percentage.
2 changes: 1 addition & 1 deletion .github/workflows/firebase_functions.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
me: firebase_functions
name: firebase_functions

on:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion functions/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = {
'quotes': [ 'error', 'single' ],
'array-bracket-spacing': [ 'error', 'always' ],
'object-curly-spacing': [ 'error', 'always' ],
'max-len': [ 'error', { code: 100, tabWidth: 2 } ],
'max-len': [ 'error', { code: 130, tabWidth: 2 } ],
'indent': [ 'error', 2 ],
'no-unused-vars': [ 'warn' ],
'new-cap': [ 'warn' ],
Expand Down
2 changes: 1 addition & 1 deletion functions/src/share/templates/footer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default `
<ul>
<li><a href="https://events.google.com/io/">Google I/O</a></li>
<li><a href="https://flutter.dev/docs/codelabs">Codelab</a></li>
<li><a href="https://medium.com/flutter/i-o-photo-booth-powered-by-flutter-firebase-fc1381264e08">How It's Made</a></li>
<li><a href="https://medium.com/flutter/how-its-made-i-o-photo-booth-3b8355d35883">How It's Made</a></li>
<li><a href="https://policies.google.com/terms">Terms of Service</a></li>
<li><a href="https://policies.google.com/privacy">Privacy Policy</a></li>
</ul>
Expand Down
5 changes: 2 additions & 3 deletions functions/src/share/templates/notfound.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ export default `
<img src="{{{assetUrls.notFoundPhoto}}}">
</div>
<div class="text">
<h1>Photo taken with Flutter</h1>
<h2>Join the fun! Grab a photo with your favorite Google mascot
at the I/O Photo Booth.</h2>
<h1>Taken with I/O Photo Booth</h1>
<h2>Oops! This photo is gone, but that doesn't mean the fun has to end.</h2>
<a class="share-btn" href="/">Take your own</a>
</div>
</main>
Expand Down
5 changes: 3 additions & 2 deletions functions/src/share/templates/share.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ export default `
<img src="{{{shareImageUrl}}}">
</div>
<div class="text">
<h1>Photo taken with Flutter</h1>
<h2>Oops! This photo is gone, but that doesn't mean the fun has to end.</h2>
<h1>Taken with I/O Photo Booth</h1>
<h2>Join the fun! Grab a photo with your favorite Google mascot
at the I/O Photo Booth.</h2>
<a class="share-btn" href="/">Get started</a>
</div>
</main>
Expand Down
57 changes: 43 additions & 14 deletions functions/src/share/templates/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ body {
.fixed-photos {
position: fixed;
top: 0;
background-repeat: no-repeat;
background-size: contain;
z-index: 1;
Expand All @@ -59,7 +58,7 @@ main {
.share-image img {
width: 100%;
box-shadow: -3px 9px 7px 1px rgba(0, 0, 0, 0.4);
box-shadow: -3px 9px 7px 1px rgba(0, 0, 0, 0.3);
}
.share-image.no-shadow img {
Expand All @@ -75,16 +74,16 @@ h1, h2 {
h1 {
line-height: 1.2;
font-size: 32px;
font-weight: 700;
width: 67%;
margin: 0 auto 25px;
font-weight: 500;
width: 80%;
margin: 0 auto 15px;
}
h2 {
line-height: 1.3;
font-size: 18px;
font-weight: 100;
width: 75%;
width: 85%;
margin: 0 auto 35px;
}
Expand Down Expand Up @@ -151,6 +150,11 @@ footer li {
margin-left: 1rem;
}
@media (min-width: 375px) {
h1 { width: 67%; }
h2 { width: 75%; }
}
@media (min-width: 768px) {
.backdrop {
background-image: url("{{{assetUrls.bg}}}");
Expand All @@ -161,30 +165,33 @@ footer li {
}
.fixed-photos.left {
left: -22%;
top: -151px;
left: -550px;
}
.fixed-photos.right {
right: -22%;
top: -110px;
right: -550px;
}
.share-image {
margin: 4.25rem auto 3rem;
width: 710px;
position: relative;
left: -22px;
width: calc(100vh * 0.7);
max-width: 740px;
}
h1, h2 {
width: 100%;
}
h1 {
font-size: 56px;
font-size: 44px;
}
h2 {
font-size: 24px;
font-size: 21px;
}
.share-btn {
Expand All @@ -204,13 +211,35 @@ footer li {
}
}
@media (min-width: 1700px) {
@media (min-width: 992px) {
.fixed-photos.left {
left: -400px;
}
.fixed-photos.right {
right: -400px;
}
}
@media (min-width: 1200px) {}
@media (min-width: 1644px) {
h1 { font-size: 56px; }
h2 { font-size: 24px; }
}
@media (min-width: 1920px) {
.fixed-photos.left {
left: -10%;
left: -150px;
}
.fixed-photos.right {
right: -10%;
right: -150px;
}
.share-image {
margin-top: 9.5rem;
margin-bottom: 4rem;
}
}
`;
2 changes: 1 addition & 1 deletion lib/footer/widgets/footer_link.dart
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class FooterHowItsMadeLink extends StatelessWidget {

return FooterLink(
link:
'https://medium.com/flutter/i-o-photo-booth-powered-by-flutter-firebase-fc1381264e08',
'https://medium.com/flutter/how-its-made-i-o-photo-booth-3b8355d35883',
text: l10n.footerHowItsMadeLinkText,
);
}
Expand Down
Loading

0 comments on commit 555d340

Please sign in to comment.