Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_adaptive_scaffold] allow users to override navigation rail padding from AdaptiveScaffold constructor #8433

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jmiller-pwi
Copy link

  1. Moved the default padding value into the body of AdaptiveScaffold.standardNavigationRail, and made the padding property an optional nullable value.
  2. Added an optional nullable EdgeInsetsGeometry parameter AdaptiveScaffold.navigationRailPadding to the constructor, which is passed into the navigation rail in build.

Fixes issue #161670

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant