[camera] Add API support query for image streaming (app-facing) #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
requested changes
Jan 14, 2025
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | |||
| * Updates example to dispose animation controllers and curved animations. | |||
| * Adds API support query for image streaming. | |||
There was a problem hiding this comment.
Since this adds a new method (supportsImageStreaming()), this should be a minor bump to 0.11.1. Also, this should also be moved to be listed first since its the meaningful change of the version bump.
liff
force-pushed
the
supportsImageStreaming+app-facing
branch
from
529b786 to
5b83416
Compare
Bring the minimums match those in `camera_android_camerax`.
liff
force-pushed
the
supportsImageStreaming+app-facing
branch
from
a81f8df to
d8cb479
Compare
|
Updated minimum Flutter/Dart SDK requirements due to the update in #8384. |
stuartmorgan
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
LGTM
@bparrishMines Once you re-review this should be good to autosubmit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final step for introducing the
supportsImageStreamingquery method. Expose it throughCameraController.Previous steps:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.