[camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests #8363
+928
−551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
reviewed
Jan 3, 2025
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCaptureDeviceControlling.m
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Jan 8, 2025
hellohuanlin
reviewed
Jan 8, 2025
| error:(NSError **)error; | ||
| @end | ||
|
|
||
| @interface AVCaptureDevice (FLTCaptureDeviceControlling) <FLTCaptureDeviceControlling> |
There was a problem hiding this comment.
I'd just call the protocol FLTCaptureDevice since it's a noun (rather than a capability), as discussed in the design doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #8342. This should be merged after #8351
AvailableCamerasTests.m,CameraOrientationTests.mandThreadSafeEventChannelTests.mFLTEventChannelandFLTCameraDeviceDiscoveringPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.