Re-enable the verify Gradle task and have Kokoro run it again #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwren
force-pushed
the
gradle_2.1_7670_02
branch
3 times, most recently
from
718baed to
bebaef5
Compare
elliette
reviewed
Nov 15, 2024
| ide(IntelliJPlatformType.IntellijIdeaCommunity, ideaVersion) | ||
| } | ||
| recommended() | ||
| // select { |
There was a problem hiding this comment.
This is still meant to be commented out?
elliette
reviewed
Nov 15, 2024
| ide(IntelliJPlatformType.IntellijIdeaCommunity, ideaVersion) | ||
| } | ||
| recommended() | ||
| // select { |
elliette
reviewed
Nov 15, 2024
| @@ -19,19 +19,33 @@ class VerifyCommand extends ProductCommand { | |||
|
|
|||
| @override | |||
| Future<int> doit() async { | |||
| // run './gradlew verifyPluginProjectConfiguration' | |||
| // run './gradlew verifyPluginStructure' | |||
There was a problem hiding this comment.
Is this meant be repeated twice?
elliette
approved these changes
Nov 15, 2024
This is follow-up work for flutter#7774 and flutter#7670
jwren
force-pushed
the
gradle_2.1_7670_02
branch
from
bebaef5 to
56ccd93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up work for #7774 and #7670