Ide feature

[helin24]

Addresses #7100

CC @kenzieschmoll

[jwren]

LGTM.

Add a URL reference here or in DevToolsUrl.java that points to #7100 for documentation.

[kenzieschmoll]

is it possible that a user can have the openOnAppLaunch setting on, and also manually open the Inspector tool window? I would think we would only want ON_DEBUG_AUTOMATIC if a user did not manually open the tool window.

[helin24]

Hmm yeah a user could open their project, and then before they run their app open the inspector tool window. I can change how we're setting openOnAppLaunch to only be true if the tool window was automatically opened.

[kenzieschmoll]

Open question: can we differentiate when the user manually opened the tool window vs when the tool window was already opened (not automatically opened due to a setting) and therefore automatically showed the inspector when a debug session was started?

[helin24]

Open question: can we differentiate when the user manually opened the tool window vs when the tool window was already opened (not automatically opened due to a setting) and therefore automatically showed the inspector when a debug session was started?

The last commit distinguishes these two, but to be clear, let's make sure these examples would be labeled as expected:

1. A user starts with tool window closed but with setting "auto open on app run" true. When they run an app, the tool window opens without their input and DevTools appears --> ON_DEBUG_AUTOMATIC
2. The same user stops running their app, but the tool window remains open. They run their app again, and DevTools appears --> TOOL_WINDOW
3. The same user stops running their app and closes the tool window. They run their app again, and the tool window opens automatically, DevTools appears --> ON_DEBUG_AUTOMATIC

Is that what we're hoping for? Case 2 seems a little odd to me because the tool window doesn't close when an app stops running (should it? probably a bigger change though)

[kenzieschmoll]

Case 2 seems fine to me because this scenario could happen for a user regardless of whether they have the on_debug_automatic setting enabled or not.

This makes me think though, should we further distinguish TOOL_WINDOW to be TOOL_WINDOW_RELOAD and TOOL_WINDOW_OPEN ? Which would distinguish when the tool window loads devtools because it was already open vs when the tool window loads devtools because the user clicked on the tool window tab.

@jacob314 thoughts?

[jacob314]

Case 2 seems fine to me because this scenario could happen for a user regardless of whether they have the on_debug_automatic setting enabled or not.

This makes me think though, should we further distinguish TOOL_WINDOW to be TOOL_WINDOW_RELOAD and TOOL_WINDOW_OPEN ? Which would distinguish when the tool window loads devtools because it was already open vs when the tool window loads devtools because the user clicked on the tool window tab.

@jacob314 thoughts?

Seems reasonable if it makes it easier to get apples-to-apples comparisons between VSCode and IntelliJ usage. Aside from that, I'm not sure it matters much as daily/weekly active user and session length metrics are probably more important than raw numbers of opens for understanding adoption.

[helin24]

I think it would be possible to distinguish TOOL_WINDOW_RELOAD and TOOL_WINDOW_OPEN, but I'm not sure if this is useful for comparing with VS Code - @kenzieschmoll I'll leave it up to you.

[helin24]

This will now distinguish the reload and open cases