-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOJIRA: update GitHub actions versions #87
Conversation
Did the node 16 tests fail originally? |
6ee30f4
to
f5a8786
Compare
@amb26 I reset back to using the newer versions of node in CI. You can see from the details of the runs that they fail on macOS with node 16. Looking at the logs it seems to be failing on node gyp. 8_tests (macOS-latest, 16.x).txt Which I believe is related to ( electron/rebuild#1116 ) and looks like it has something to do with an incompatibility between node gyp and python versions. |
@amb26 Node Gyp appears to be coming via: [email protected]>[email protected]>[email protected]>[email protected] |
@amb26 this issue ( nodejs/node-gyp#2869 ) was addressed in node-gyp v10+ however if you look at the logs here it is using [email protected]. Although it isn't yet clear to me how node-gyp-build sources node-gyp. |
In speaking with @amb26 in the fluid general channel today, we may be able to remove the failing tests. |
@amb26 for now I've just removed testing for Node 20 and 22 environments. It just tests Node 16 and 18 for which all the tests pass. I think we might want to investigate more for why Node 20 and 22 are failing, but I think we might want to update dependencies and etc as well. This will get us at least past the point where ci would stop working next month. |
In February 2025 v1 and v2 of the actions/cache GitHub actions will no longer work. This needs to be updated to prevent ci breakages.
see: https://github.com/actions/cache?tab=readme-ov-file#%EF%B8%8F-important-changes
Also updated to recent version of node for testing with.