Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA: update GitHub actions versions #87

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

jobara
Copy link
Member

@jobara jobara commented Dec 12, 2024

In February 2025 v1 and v2 of the actions/cache GitHub actions will no longer work. This needs to be updated to prevent ci breakages.

see: https://github.com/actions/cache?tab=readme-ov-file#%EF%B8%8F-important-changes

Also updated to recent version of node for testing with.

@jobara jobara requested a review from amb26 December 12, 2024 18:33
@amb26
Copy link
Member

amb26 commented Dec 12, 2024

Did the node 16 tests fail originally?

@jobara jobara force-pushed the update-github-actions branch from 6ee30f4 to f5a8786 Compare January 6, 2025 16:03
@jobara
Copy link
Member Author

jobara commented Jan 6, 2025

Did the node 16 tests fail originally?

@amb26 I reset back to using the newer versions of node in CI. You can see from the details of the runs that they fail on macOS with node 16. Looking at the logs it seems to be failing on node gyp.

8_tests (macOS-latest, 16.x).txt

Which I believe is related to ( electron/rebuild#1116 ) and looks like it has something to do with an incompatibility between node gyp and python versions.

@jobara
Copy link
Member Author

jobara commented Jan 6, 2025

@amb26 Node Gyp appears to be coming via:

[email protected]>[email protected]>[email protected]>[email protected]

@jobara
Copy link
Member Author

jobara commented Jan 6, 2025

@amb26 this issue ( nodejs/node-gyp#2869 ) was addressed in node-gyp v10+ however if you look at the logs here it is using [email protected]. Although it isn't yet clear to me how node-gyp-build sources node-gyp.

@jobara
Copy link
Member Author

jobara commented Jan 15, 2025

In speaking with @amb26 in the fluid general channel today, we may be able to remove the failing tests.

@jobara
Copy link
Member Author

jobara commented Jan 23, 2025

@amb26 for now I've just removed testing for Node 20 and 22 environments. It just tests Node 16 and 18 for which all the tests pass. I think we might want to investigate more for why Node 20 and 22 are failing, but I think we might want to update dependencies and etc as well. This will get us at least past the point where ci would stop working next month.

@amb26 amb26 merged commit caa5bb7 into fluid-project:main Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants