[wip] add cache worker set interface and use it to replace all statefulset interfaces in alluxio controller logic #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o runtime
Ⅰ. Describe what this PR does
1.在alluxio runtime type中增加workerType字段，用来指示worker类型（STS,ASTS,DaemonSet）
2.增加cacheworkerset 定义以及相关属性的GET/SET操作（pkg/types/cacheworkerset/interface.go）
3.替换ddc/alluxio下的alluxio的GetStatefulset和GetWorkerAsStatefulset,将其都替换为Get(Worker)CacheWorkerSet的形式，接管所有的原先Statefulset的操作；（目前还没有对除了alluxio外其他runtime的代码进行上述的替换）
4.引入了openkruise依赖后，根据它的特性，只需要手动对work pod的label进行patch SpecifiedDeleteKey = "apps.kruise.io/specified-delete"，且这些worker pod被openkruise advanced statefulset接管，那么就可以做到指定该pod下线了。
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews