Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the invalid fmt of dataload cronJob helm template #4360

Conversation

Syspretor
Copy link
Collaborator

Ⅰ. Describe what this PR does

Incorrect indentation in the Helm template can lead to template rendering failures. In the current dataload operations across all runtimes, many of the configurations within the CronJob's template spec, such as nodeSelector, affinity, tolerations, and imagePullSecrets, have incorrect indentation. This causes issues when users configure these settings in the dataload and specify the usage of policy: Cron, resulting in a failure in the CronJob template rendering.

Ⅱ. Does this pull request fix one issue?

fixes #4358

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Use the following example to ensure cronJob can work well

apiVersion: data.fluid.io/v1alpha1
kind: DataLoad
metadata:
  name: data-warmup-cron
spec:
  nodeSelector:
    cronjob: "true"
  imagePullSecrets:
  - name: acs-dev-acr
  dataset:
    name: demo-1
    namespace: default
  loadMetadata: true
  policy: Cron
  schedule: "*/1 * * * *"

@Syspretor Syspretor changed the title Fix: fix the invalid fmt of dataload cronJob helm template [WIP] Fix: fix the invalid fmt of dataload cronJob helm template Oct 16, 2024
@Syspretor Syspretor force-pushed the fix/fix-invalid-helm-template-fmt-of-dataload-cronJob branch from 6d15585 to dcf8d83 Compare October 16, 2024 02:42
@Syspretor Syspretor changed the title [WIP] Fix: fix the invalid fmt of dataload cronJob helm template Fix: fix the invalid fmt of dataload cronJob helm template Oct 16, 2024
@Syspretor Syspretor force-pushed the fix/fix-invalid-helm-template-fmt-of-dataload-cronJob branch from dcf8d83 to 81995af Compare October 16, 2024 05:39
Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 3e38c94 into fluid-cloudnative:master Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fail to install cron dataload job when setting nodeSelector
2 participants