Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hierarchical imagePullSecrets configuration in AlluxioRuntime #4242

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

EvanCley
Copy link
Contributor

Ⅰ. Describe what this PR does

feature #4221
Support hierarchical imagePullSecrets configuration in AlluxioRuntime CRD

Ⅱ. Does this pull request fix one issue?

fixes #4221

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

add test cases in TestGenerateAlluxioValueFil()/TestTransformMaster()/TestTransformWorker()/TestParseFuseImage()

Ⅳ. Describe how to verify it

create several secrets and add below fields in runtime.yaml, then create the AlluxioRuntime and describe the field imagePullSecrets in master/worker/fuse pod

apiVersion: data.fluid.io/v1alpha1
kind: AlluxioRuntime
metadata:
  name: hbase
spec:
  replicas: 1
  tieredstore:
    levels:
      - mediumtype: MEM
        path: /dev/shm
        quota: 2Gi
        high: "0.95"
        low: "0.7"
  imagePullSecrets:
    - name: "secret-runtime"
  master:
    imagePullSecrets:
      - name: "secret-master"
  worker:
    imagePullSecrets:
      - name: "secret-worker"
  fuse:
    imagePullSecrets:
      - name: "secret-fuse" 

Ⅴ. Special notes for reviews

Copy link

fluid-e2e-bot bot commented Jul 30, 2024

Hi @EvanCley. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang cheyang requested a review from allenhaozi July 30, 2024 12:22
@cheyang
Copy link
Collaborator

cheyang commented Jul 30, 2024

@EvanCley CRD validation failed. Please use 'make update-crd' to keep CRDs latest

@EvanCley EvanCley force-pushed the dev/alluxio branch 2 times, most recently from 729edec to 2390346 Compare July 30, 2024 15:13
@EvanCley
Copy link
Contributor Author

@EvanCley CRD validation failed. Please use 'make update-crd' to keep CRDs latest

OK, have done

imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- toYaml .Values.master.imagePullSecrets | nindent 8 }}
{{- else if .Values.imagePullSecrets}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a whitespace before }} in the template directive.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fuse not master imagePullSecrets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fuse not master imagePullSecrets

thanks for point that, have amended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a whitespace before }} in the template directive.

ok, have done

Copy link

sonarcloud bot commented Aug 1, 2024

@cheyang
Copy link
Collaborator

cheyang commented Aug 3, 2024

@allenhaozi Do you have any comments on this PR?

@allenhaozi
Copy link
Contributor

allenhaozi commented Aug 3, 2024

@allenhaozi Do you have any comments on this PR?

@cheyang LGTM, awesome job

@allenhaozi
Copy link
Contributor

/lgtm

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 79073df into fluid-cloudnative:master Aug 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURES] Support hierarchical imagePullSecrets configuration in AlluxioRuntime CRD
4 participants