Fix add jindocache engine for jindodata 5.0 beta release #3346

frankleaf · 2023-07-20T02:39:00Z

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cheyang · 2023-07-20T02:42:22Z

.dlv/config.yml

@@ -0,0 +1,54 @@
+# Configuration file for the delve debugger.


Please remove the file, it's for debugging.

cheyang · 2023-07-20T02:43:17Z

Library/Caches/go-build/README

@@ -0,0 +1,4 @@
+This directory holds cached build artifacts from the Go build system.


Please delete this file.

cheyang · 2023-07-20T02:44:49Z

pkg/ddc/jindocache/sync_runtime_test.go

@@ -0,0 +1,513 @@
+/*
+Copyright 2022 The Fluid Authors.


The header year should be 2023.

cheyang · 2023-07-20T02:48:35Z

charts/jindocache/templates/fuse/daemonset.yaml

+apiVersion: apps/v1
+kind: DaemonSet
+metadata:
+  name: {{ template "jindofs.fullname" . }}-fuse


If the chart name is changed to jindocache, I think the name jindofs should be changed to jindocache.

cheyang · 2023-07-20T02:49:23Z

charts/jindocache/templates/fuse/daemonset.yaml

+    chart: {{ template "jindofs.chart" . }}
+    release: {{ .Release.Name }}
+    heritage: {{ .Release.Service }}
+    role: jindofs-fuse


Should the role name be jindocache-fuse?

cheyang · 2023-07-20T04:01:07Z

@frankleaf please fix the unit test first. thanks.

codecov · 2023-07-20T04:22:55Z

Codecov Report

Merging #3346 (af4b729) into master (e180802) will decrease coverage by 0.92%.
The diff coverage is 55.97%.

❗ Current head af4b729 differs from pull request most recent head 8b2740d. Consider uploading reports for the commit 8b2740d to get more accurate results

@@            Coverage Diff             @@
##           master    #3346      +/-   ##
==========================================
- Coverage   65.43%   64.51%   -0.92%     
==========================================
  Files         402      432      +30     
  Lines       23244    25745    +2501     
==========================================
+ Hits        15209    16609    +1400     
- Misses       6254     7165     +911     
- Partials     1781     1971     +190

Impacted Files	Coverage Δ
pkg/ddc/jindocache/data_migrate.go	`0.00% <0.00%> (ø)`
pkg/ddc/jindocache/operate.go	`0.00% <0.00%> (ø)`
pkg/ddc/jindocache/ufs.go	`0.00% <0.00%> (ø)`
pkg/ddc/jindocache/ufs_internal.go	`0.00% <0.00%> (ø)`
pkg/ddc/jindocache/transform_hadoop_config.go	`13.63% <13.63%> (ø)`
pkg/ddc/jindocache/status.go	`20.54% <20.54%> (ø)`
pkg/ddc/jindocache/master.go	`21.73% <21.73%> (ø)`
pkg/ddc/jindocache/sync_runtime.go	`33.60% <33.60%> (ø)`
pkg/ddc/jindocache/shutdown.go	`36.60% <36.60%> (ø)`
pkg/ddc/jindocache/port_parser.go	`45.45% <45.45%> (ø)`
... and 20 more

Signed-off-by: frankleaf <[email protected]>

cheyang · 2023-07-20T07:37:13Z

/test fluid-e2e

cheyang · 2023-07-20T07:39:29Z

pkg/ddc/factory.go

-		"efc":      efc.Build,
+		"alluxio":    alluxio.Build,
+		"jindo":      jindo.Build,
+		"jindofsx":   jindofsx.Build,


How about puting jindo,jindofsx and jindocache together?

cheyang · 2023-07-20T07:47:19Z

.gitignore

@@ -40,3 +40,6 @@ sdk
 **/__debug_bin
 **/__pycache__

+# local related


I think it's not neccessay for developers. Please remove it.

Signed-off-by: frankleaf <[email protected]>

sonarcloud · 2023-07-20T13:25:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
130 Code Smells

No Coverage information
22.0% Duplication

cheyang · 2023-07-21T07:14:47Z

/test fluid-e2e

cheyang · 2023-07-21T08:37:21Z

/retest

cheyang · 2023-07-21T09:29:10Z

/test fluid-e2e

cheyang

/lgtm
/approve

fluid-e2e-bot · 2023-07-21T09:52:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cheyang requested changes Jul 20, 2023

View reviewed changes

cheyang reviewed Jul 20, 2023

View reviewed changes

frankleaf added 7 commits July 20, 2023 15:25

add jindocache engine

236edd3

Signed-off-by: frankleaf <[email protected]>

add jindocache engine

2ddb176

Signed-off-by: frankleaf <[email protected]>

add jindocache engine

e41d5ce

Signed-off-by: frankleaf <[email protected]>

update readMe

397b933

Signed-off-by: frankleaf <[email protected]>

fix time

a05e5f3

Signed-off-by: frankleaf <[email protected]>

fix file

c178a62

Signed-off-by: frankleaf <[email protected]>

update imageTagSupportAKFile

dac357b

Signed-off-by: frankleaf <[email protected]>

frankleaf force-pushed the dev_718 branch from 21c8472 to dac357b Compare July 20, 2023 07:25

add jindocache dataloader

935144d

Signed-off-by: frankleaf <[email protected]>

cheyang reviewed Jul 20, 2023

View reviewed changes

frankleaf added 3 commits July 20, 2023 16:10

fix gitignore

5533673

Signed-off-by: frankleaf <[email protected]>

reorder

88d73b2

Signed-off-by: frankleaf <[email protected]>

reorder

8b2740d

Signed-off-by: frankleaf <[email protected]>

cheyang approved these changes Jul 21, 2023

View reviewed changes

fluid-e2e-bot bot assigned cheyang Jul 21, 2023

fluid-e2e-bot bot added the lgtm label Jul 21, 2023

fluid-e2e-bot bot added the approved label Jul 21, 2023

fluid-e2e-bot bot merged commit 556a605 into fluid-cloudnative:master Jul 21, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix add jindocache engine for jindodata 5.0 beta release #3346

Fix add jindocache engine for jindodata 5.0 beta release #3346

frankleaf commented Jul 20, 2023

cheyang Jul 20, 2023

frankleaf Jul 21, 2023

cheyang Jul 20, 2023

frankleaf Jul 21, 2023

cheyang Jul 20, 2023

cheyang Jul 20, 2023

frankleaf Jul 21, 2023

cheyang Jul 20, 2023

frankleaf Jul 21, 2023

cheyang commented Jul 20, 2023

codecov bot commented Jul 20, 2023 •

edited

Loading

cheyang commented Jul 20, 2023

cheyang Jul 20, 2023

frankleaf Jul 20, 2023

cheyang Jul 20, 2023

frankleaf Jul 20, 2023

sonarcloud bot commented Jul 20, 2023

cheyang commented Jul 21, 2023

cheyang commented Jul 21, 2023

cheyang commented Jul 21, 2023

cheyang left a comment

fluid-e2e-bot bot commented Jul 21, 2023

		@@ -0,0 +1,54 @@
		# Configuration file for the delve debugger.

		@@ -0,0 +1,4 @@
		This directory holds cached build artifacts from the Go build system.

Fix add jindocache engine for jindodata 5.0 beta release #3346

Fix add jindocache engine for jindodata 5.0 beta release #3346

Conversation

frankleaf commented Jul 20, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cheyang commented Jul 20, 2023

codecov bot commented Jul 20, 2023 • edited Loading

Codecov Report

cheyang commented Jul 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 20, 2023

cheyang commented Jul 21, 2023

cheyang commented Jul 21, 2023

cheyang commented Jul 21, 2023

cheyang left a comment

Choose a reason for hiding this comment

fluid-e2e-bot bot commented Jul 21, 2023

codecov bot commented Jul 20, 2023 •

edited

Loading