-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix worker&fuse options & worker tiredstore #3344
fix worker&fuse options & worker tiredstore #3344
Conversation
Signed-off-by: zwwhdls <[email protected]>
Skipping CI for Draft Pull Request. |
/test fluid-e2e |
Signed-off-by: zwwhdls <[email protected]>
/retest |
/test fluid-e2e |
Signed-off-by: zwwhdls <[email protected]>
/test fluid-e2e |
Codecov Report
@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
- Coverage 65.43% 65.41% -0.02%
==========================================
Files 402 402
Lines 23244 23286 +42
==========================================
+ Hits 15209 15232 +23
- Misses 6254 6267 +13
- Partials 1781 1787 +6
|
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
// cacheSize is in MiB | ||
cachesize = cacheSizeMB * 1024 * 1024 | ||
} | ||
if cachesize != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the states.cacheCapacity
may not be accurate when some of the juicefs worker is not Running. Can we use ready worker replicas as its multiplier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: zwwhdls <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/test fluid-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix worker&fuse options & worker tiredstore Signed-off-by: zwwhdls <[email protected]> * fix staticcheck Signed-off-by: zwwhdls <[email protected]> * fix dataset capacity & send deprecated event Signed-off-by: zwwhdls <[email protected]> * fix typo & add unit test Signed-off-by: zwwhdls <[email protected]> * fix worker metric port Signed-off-by: zwwhdls <[email protected]> * fix static check Signed-off-by: zwwhdls <[email protected]> * fix ready worker num in cache capacity Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews