add ut for status_handler (#3376)

Signed-off-by: wangshulin <[email protected]>
fluid-cloudnative · Aug 4, 2023 · c153ca5 · c153ca5
1 parent 9a2aa52
commit c153ca5
Show file tree

Hide file tree

Showing 4 changed files with 656 additions and 0 deletions.
diff --git a/pkg/controllers/v1alpha1/databackup/status_handler_test.go b/pkg/controllers/v1alpha1/databackup/status_handler_test.go
@@ -0,0 +1,101 @@
+/*
+  Copyright 2023 The Fluid Authors.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+*/
+
+package databackup
+
+import (
+	"testing"
+
+	"github.com/fluid-cloudnative/fluid/api/v1alpha1"
+	"github.com/fluid-cloudnative/fluid/pkg/common"
+	cruntime "github.com/fluid-cloudnative/fluid/pkg/runtime"
+	"github.com/fluid-cloudnative/fluid/pkg/utils/fake"
+	corev1 "k8s.io/api/core/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/types"
+)
+
+func TestOnceGetOperationStatus(t *testing.T) {
+	testScheme := runtime.NewScheme()
+	_ = v1alpha1.AddToScheme(testScheme)
+	_ = corev1.AddToScheme(testScheme)
+
+	mockDataBackup := v1alpha1.DataBackup{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test",
+			Namespace: "default",
+		},
+		Spec: v1alpha1.DataBackupSpec{},
+	}
+
+	mockPod := corev1.Pod{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-pod",
+			Namespace: "default",
+		},
+		Status: corev1.PodStatus{
+			Phase: corev1.PodSucceeded,
+		},
+	}
+
+	mockFailedPod := corev1.Pod{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-pod",
+			Namespace: "default",
+		},
+		Status: corev1.PodStatus{
+			Phase: corev1.PodFailed,
+		},
+	}
+
+	testcases := []struct {
+		name          string
+		pod           corev1.Pod
+		expectedPhase common.Phase
+	}{
+		{
+			name:          "job success",
+			pod:           mockPod,
+			expectedPhase: common.PhaseComplete,
+		},
+		{
+			name:          "job failed",
+			pod:           mockFailedPod,
+			expectedPhase: common.PhaseFailed,
+		},
+	}
+
+	for _, testcase := range testcases {
+		client := fake.NewFakeClientWithScheme(testScheme, &mockDataBackup, &testcase.pod)
+		onceStatusHandler := &OnceHandler{}
+		ctx := cruntime.ReconcileRequestContext{
+			NamespacedName: types.NamespacedName{
+				Namespace: "default",
+				Name:      "",
+			},
+			Client: client,
+			Log:    fake.NullLogger(),
+		}
+		opStatus, err := onceStatusHandler.GetOperationStatus(ctx, &mockDataBackup, &mockDataBackup.Status)
+		if err != nil {
+			t.Errorf("fail to GetOperationStatus with error %v", err)
+		}
+		if opStatus.Phase != testcase.expectedPhase {
+			t.Error("Failed to GetOperationStatus", "expected phase", testcase.expectedPhase, "get", opStatus.Phase)
+		}
+	}
+}
diff --git a/pkg/controllers/v1alpha1/dataload/status_handler_test.go b/pkg/controllers/v1alpha1/dataload/status_handler_test.go
@@ -0,0 +1,226 @@
+/*
+  Copyright 2023 The Fluid Authors.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+*/
+
+package dataload
+
+import (
+	"reflect"
+	"testing"
+	"time"
+
+	"github.com/fluid-cloudnative/fluid/api/v1alpha1"
+	"github.com/fluid-cloudnative/fluid/pkg/common"
+	cruntime "github.com/fluid-cloudnative/fluid/pkg/runtime"
+	"github.com/fluid-cloudnative/fluid/pkg/utils/fake"
+	batchv1 "k8s.io/api/batch/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/types"
+)
+
+func TestOnceGetOperationStatus(t *testing.T) {
+	testScheme := runtime.NewScheme()
+	_ = v1alpha1.AddToScheme(testScheme)
+	_ = batchv1.AddToScheme(testScheme)
+
+	mockDataload := v1alpha1.DataLoad{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload",
+			Namespace: "default",
+		},
+		Spec: v1alpha1.DataLoadSpec{
+			Dataset: v1alpha1.TargetDataset{
+				Name:      "hadoop",
+				Namespace: "default",
+			},
+		},
+	}
+
+	mockJob := batchv1.Job{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload-loader-job",
+			Namespace: "default",
+		},
+		Status: batchv1.JobStatus{
+			Conditions: []batchv1.JobCondition{
+				{
+					Type:               batchv1.JobComplete,
+					LastProbeTime:      v1.NewTime(time.Now()),
+					LastTransitionTime: v1.NewTime(time.Now()),
+				},
+			},
+		},
+	}
+
+	mockFailedJob := batchv1.Job{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload-loader-job",
+			Namespace: "default",
+		},
+		Status: batchv1.JobStatus{
+			Conditions: []batchv1.JobCondition{
+				{
+					Type:               batchv1.JobFailed,
+					LastProbeTime:      v1.NewTime(time.Now()),
+					LastTransitionTime: v1.NewTime(time.Now()),
+				},
+			},
+		},
+	}
+
+	testcases := []struct {
+		name          string
+		job           batchv1.Job
+		expectedPhase common.Phase
+	}{
+		{
+			name:          "job success",
+			job:           mockJob,
+			expectedPhase: common.PhaseComplete,
+		},
+		{
+			name:          "job failed",
+			job:           mockFailedJob,
+			expectedPhase: common.PhaseFailed,
+		},
+	}
+
+	for _, testcase := range testcases {
+		client := fake.NewFakeClientWithScheme(testScheme, &mockDataload, &testcase.job)
+		onceStatusHandler := &OnceStatusHandler{Client: client}
+		ctx := cruntime.ReconcileRequestContext{
+			NamespacedName: types.NamespacedName{
+				Namespace: "default",
+				Name:      "",
+			},
+			Log: fake.NullLogger(),
+		}
+		opStatus, err := onceStatusHandler.GetOperationStatus(ctx, &mockDataload, &mockDataload.Status)
+		if err != nil {
+			t.Errorf("fail to GetOperationStatus with error %v", err)
+		}
+		if opStatus.Phase != testcase.expectedPhase {
+			t.Error("Failed to GetOperationStatus", "expected phase", testcase.expectedPhase, "get", opStatus.Phase)
+		}
+	}
+}
+
+func TestCronGetOperationStatus(t *testing.T) {
+	testScheme := runtime.NewScheme()
+	_ = v1alpha1.AddToScheme(testScheme)
+	_ = batchv1.AddToScheme(testScheme)
+
+	startTime := time.Date(2023, 8, 1, 12, 0, 0, 0, time.Local)
+	lastScheduleTime := v1.NewTime(startTime)
+	lastSuccessfulTime := v1.NewTime(startTime.Add(time.Second * 10))
+
+	mockCronDataload := v1alpha1.DataLoad{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload",
+			Namespace: "default",
+		},
+		Spec: v1alpha1.DataLoadSpec{
+			Dataset: v1alpha1.TargetDataset{
+				Name:      "hadoop",
+				Namespace: "default",
+			},
+			Policy:   "Cron",
+			Schedule: "* * * * *",
+		},
+		Status: v1alpha1.OperationStatus{
+			Phase: common.PhaseComplete,
+		},
+	}
+
+	mockCronJob := batchv1.CronJob{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload-loader-job",
+			Namespace: "default",
+		},
+		Spec: batchv1.CronJobSpec{
+			Schedule: "* * * * *",
+		},
+		Status: batchv1.CronJobStatus{
+			LastScheduleTime:   &lastScheduleTime,
+			LastSuccessfulTime: &lastSuccessfulTime,
+		},
+	}
+
+	mockJob := batchv1.Job{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload-loader-job-1",
+			Namespace: "default",
+			Labels: map[string]string{
+				"cronjob": "test-dataload-loader-job",
+			},
+			CreationTimestamp: lastScheduleTime,
+		},
+		Status: batchv1.JobStatus{
+			Conditions: []batchv1.JobCondition{
+				{
+					Type:               batchv1.JobComplete,
+					LastProbeTime:      lastSuccessfulTime,
+					LastTransitionTime: lastSuccessfulTime,
+				},
+			},
+		},
+	}
+
+	mockRunningJob := batchv1.Job{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      "test-dataload-loader-job-1",
+			Namespace: "default",
+			Labels: map[string]string{
+				"cronjob": "test-dataload-loader-job",
+			},
+			CreationTimestamp: lastScheduleTime,
+		},
+		Status: batchv1.JobStatus{},
+	}
+
+	testcases := []struct {
+		name          string
+		job           batchv1.Job
+		expectedPhase common.Phase
+	}{
+		{
+			name:          "job complete",
+			job:           mockJob,
+			expectedPhase: common.PhaseComplete,
+		},
+		{
+			name:          "job running",
+			job:           mockRunningJob,
+			expectedPhase: common.PhasePending,
+		},
+	}
+
+	for _, testcase := range testcases {
+		client := fake.NewFakeClientWithScheme(testScheme, &mockCronDataload, &mockCronJob, &testcase.job)
+		cronStatusHandler := &CronStatusHandler{Client: client}
+		ctx := cruntime.ReconcileRequestContext{Log: fake.NullLogger()}
+		opStatus, err := cronStatusHandler.GetOperationStatus(ctx, &mockCronDataload, &mockCronDataload.Status)
+		if err != nil {
+			t.Errorf("fail to GetOperationStatus with error %v", err)
+		}
+		if !reflect.DeepEqual(opStatus.LastScheduleTime, &lastScheduleTime) || !reflect.DeepEqual(opStatus.LastSuccessfulTime, &lastSuccessfulTime) {
+			t.Error("fail to get correct Operation Status", "expected LastScheduleTime", lastScheduleTime, "expected LastSuccessfulTime", lastSuccessfulTime, "get", opStatus)
+		}
+		if opStatus.Phase != testcase.expectedPhase {
+			t.Error("Failed to GetOperationStatus", "expected phase", testcase.expectedPhase, "get", opStatus.Phase)
+		}
+	}
+}