Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding namespaceClusterFbCfg to ClusterFluentBitConfig custom resource. #1380

Closed

Conversation

btalakola
Copy link

Deploy fluent-bit configmap and secret in the namespace provided in the namespaceClusterFbCfg which is used in ClusterFluentBitConfig customresource > spec section. If it is not defined, they are created in the namespace of the fluent-operator.
Signed-off-by: Bharathi Talakola [email protected]

What this PR does / why we need it:

At present "fluent-bit-config" secret is getting created in the fluent-operator namespace by default. It can be configured using "namespace" key from ClusterFluentBitConfig CRD but this namespace key is not configured at the CR level.
https://github.com/fluent/fluent-operator/blob/release-3.2/charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_clusterfluentbitconfigs.yaml#L191-L231.
Hence added namespace field to ClusterFluentBitConfig customresource > spec section.

Which issue(s) this PR fixes:

Fixes: #1365

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterFluentBitConfig
metadata:
  name: fluent-bit-config
  labels:
    app.kubernetes.io/name: fluent-bit
spec:
  namespace: "fluentbit-namespace"
  

…et in this namespace. If it is not defined, secret is in namespace of the fluent-operator.

Signed-off-by: Bharathi Talakola <[email protected]>

Signed-off-by: Bharathi <[email protected]>
@btalakola btalakola force-pushed the add-namespace-to-cluster-fbcfg branch from 30fed3d to c68379d Compare October 18, 2024 12:52
@btalakola btalakola closed this Oct 18, 2024
@btalakola btalakola deleted the add-namespace-to-cluster-fbcfg branch October 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: fluent-bit-config secret is created in fluent-operator namespace by default.
1 participant