array: fix memory overlap when removing from array by index. (#42)

Signed-off-by: Phillip Whelan <[email protected]>
fluent · Apr 8, 2024 · c86d8f3 · c86d8f3
1 parent 0a79b7c
commit c86d8f3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/cfl_array.c b/src/cfl_array.c
@@ -88,9 +88,9 @@ int cfl_array_remove_by_index(struct cfl_array *array,
     cfl_variant_destroy(array->entries[position]);
 
     if (position != array->entry_count - 1) {
-        memcpy(&array->entries[position],
-               &array->entries[position + 1],
-               sizeof(void *) * (array->entry_count - (position + 1)));
+        memmove(&array->entries[position],
+                &array->entries[position + 1],
+                sizeof(void *) * (array->entry_count - (position + 1)));
     }
     else {
         array->entries[position] = NULL;