Expose Multi-File AST #965
Conversation
LukasPietzschmann
added
enhancement
|
@EagleoutIce if you've got time, you can take a look at the code. There is still a TODO I have to implement, but the rest should reviewable :) Also, there's an error at the end of this line: flowr/src/cli/repl/server/connection.ts Line 153 in 7dcdbe6 I can't really make sense of it. Maybe you can assist me with that. |
|
sadly i do not have a lot of time at the moment, but looking at it the first time, suggest that it may be the |
* feat: first attempt at the new getLineage command * feat: walk additional edges for determining the lineage * feat: store lineage IDs in a set * feat: prevent infinite recursion when determining the lineage IDs * feat-fix: fixed lineage network request * feat-fix: get the dfg and ast from the pipeline in the correct way * doc: added lineage request doc * feat-fix: add filetoken to error messages Co-authored-by: Florian Sihler <[email protected]> * feat-fix: updated comment for better clarity * feat-fix: more guards, more better * feat-fix: clearer function interface * feat-fix: removed unused import No I didn't push with --no-verify * feat-fix: removed console.log Co-authored-by: Florian Sihler <[email protected]> * feat-fix: criteria resolve now only requires an idmap * test(lineage): basic test setup * lint-fix: handle linter issues and empty test labels * refactor(lineage): remove redundant promise * doc(lineage): refine wiki entries --------- Co-authored-by: Florian Sihler <[email protected]>
…d Lineage Command
|
what happened with you now being a co-signed author on all of these commits? |
|
I rebased this branch onto main ':) |
|
I pushed a respective fix which causes the parsing to happen sequentially! However, I still noticed that any additional file is normalized an additional time; i.e. there is another normalize call for this. Can you track that down? it is probably due to someone somewhere still not assuming the multifile ast exists (probably my old code) and just triggering a new parsing |
|
If you are ready, i will take on the merge regarding the 3-version upgrades we have |
|
Additionally, the case you established should probably be added as a test case to avoid regression. |
No description provided.