Skip to content

Commit

Permalink
feat-fix: increase r version timeout in r shell (#760)
Browse files Browse the repository at this point in the history 
Co-authored-by: Florian Sihler <[email protected]>
  • Loading branch information
@Ellpeck @EagleoutIce
Ellpeck and EagleoutIce authored May 5, 2024
1 parent 7f0b635 commit 0fc1abd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/r-bridge/shell.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class RShell {
// retrieve raw version:
const result = await this.sendCommandWithOutput(`cat(paste0(R.version$major,".",R.version$minor), ${ts2r(this.options.eol)})`, {
timeout: {
ms: 1000,
ms: 5000,
resetOnNewData: false,
// just resolve on timeout and handle the empty array case below
onTimeout: resolve => resolve([])
Expand Down

2 comments on commit 0fc1abd

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"artificial" Benchmark Suite

Benchmark suite Current: 0fc1abd Previous: 1e5ddeb Ratio
Retrieve AST from R code 302.705345 ms 305.50355490909095 ms 0.99
Normalize R AST 33.78476431818182 ms 33.04192136363636 ms 1.02
Produce dataflow information 67.40989095454545 ms 66.58585145454545 ms 1.01
Total per-file 1515.4460266818182 ms 1512.547620909091 ms 1.00
Static slicing 1.387035918620317 ms (1.2872853564749311) 1.3817132831241319 ms (1.27303105869458) 1.00
Reconstruct code 0.4538698634875501 ms (0.24840032436889045) 0.45135141022522257 ms (0.25927254974160097) 1.01
Total per-slice 1.857527025274826 ms (1.3471459841968048) 1.8475447304133532 ms (1.3326721674469058) 1.01
failed to reconstruct/re-parse 0 # 0 # 1
times hit threshold 0 # 0 # 1
reduction (characters) 0.7329390759026897 # 0.7329390759026897 # 1
reduction (normalized tokens) 0.7209834969577295 # 0.7209834969577295 # 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"social-science" Benchmark Suite

Benchmark suite Current: 0fc1abd Previous: 1e5ddeb Ratio
Retrieve AST from R code 300.91599626 ms 330.55613118 ms 0.91
Normalize R AST 34.57243208 ms 36.10837608 ms 0.96
Produce dataflow information 179.2860929 ms 188.6117503 ms 0.95
Total per-file 3602.9288386 ms 3858.78617088 ms 0.93
Static slicing 8.368337176133526 ms (14.488018010273757) 8.763488287471356 ms (15.142795018273485) 0.95
Reconstruct code 0.4640423005099645 ms (0.22432270380183172) 0.6295735167403027 ms (0.28826473087031307) 0.74
Total per-slice 8.842394213965727 ms (14.600183820416719) 9.403718790030862 ms (15.25727767695505) 0.94
failed to reconstruct/re-parse 7 # 7 # 1
times hit threshold 298 # 298 # 1
reduction (characters) 0.8935817303062389 # 0.8935817303062389 # 1
reduction (normalized tokens) 0.8531248144961375 # 0.8531248144961375 # 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.