[release:patch] Fix: Dependency Query with Aliases

flowr-analysis · Nov 4, 2024 · 0d1268d · 0d1268d · EagleoutIce · Nov 4, 2024
1 parent e84bdef
commit 0d1268d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/queries/catalog/dependencies-query/dependencies-query-executor.ts b/src/queries/catalog/dependencies-query/dependencies-query-executor.ts
@@ -100,7 +100,7 @@ function makeCallContextQuery(functions: readonly FunctionInfo[], kind: string):
 	return functions.map(f => ({
 		type:           'call-context',
 		callName:       f.name,
-		includeAliases: true,
+		includeAliases: false,
 		callNameExact:  true,
 		subkind:        f.name,
 		linkTo:         f.linkTo ? { type: 'link-to-last-call', callName: f.linkTo } : undefined,

diff --git a/test/functionality/dataflow/query/dependencies-query-tests.ts b/test/functionality/dataflow/query/dependencies-query-tests.ts
@@ -72,10 +72,6 @@ describe('Dependencies Query', withShell(shell => {
 			{ nodeId: '1@p_load', functionName: 'p_load', libraryName: 'c' }
 		] });
 
-		testQuery('Call with Alias', 'foo <- library\nfoo(x)', { libraries: [
-			{ nodeId: '2@foo', functionName: 'foo', libraryName: 'x' }
-		] });
-
 		testQuery('Load implicitly', 'foo::x\nbar:::y()', { libraries: [
 			{ nodeId: '1@x', functionName: '::', libraryName: 'foo' },
 			{ nodeId: '2@y', functionName: ':::', libraryName: 'bar' }
Benchmark suite	Current: `0d1268d`	Previous: `b1b2a4f`	Ratio
`Retrieve AST from R code`	`237.85305927272728` ms (`97.36861369002281`)	`235.55314422727272` ms (`96.72403503863565`)	`1.01`
`Normalize R AST`	`16.982624772727274` ms (`30.42886266900597`)	`17.58143390909091` ms (`31.74556724684041`)	`0.97`
`Produce dataflow information`	`60.41169277272727` ms (`128.7371176899317`)	`60.37620659090909` ms (`128.80057198423427`)	`1.00`
`Total per-file`	`833.961438` ms (`1514.7315556086162`)	`836.2917278181819` ms (`1520.8800616695478`)	`1.00`
`Static slicing`	`2.0461436166648226` ms (`1.2405957027340997`)	`2.0412247343237886` ms (`1.2114179518839105`)	`1.00`
`Reconstruct code`	`0.23572579664556767` ms (`0.19160803373208626`)	`0.22918887047809808` ms (`0.17190632838553319`)	`1.03`
`Total per-slice`	`2.2952539344461735` ms (`1.3064191460121453`)	`2.284079723104182` ms (`1.2742262921798237`)	`1.00`
`failed to reconstruct/re-parse`	`0` #	`0` #	`1`
`times hit threshold`	`0` #	`0` #	`1`
`reduction (characters)`	`0.7869360165281424` #	`0.7869360165281424` #	`1`
`reduction (normalized tokens)`	`0.7639690077689504` #	`0.7639690077689504` #	`1`
`memory (df-graph)`	`95.46617542613636` KiB (`244.77619956879823`)	`95.46617542613636` KiB (`244.77619956879823`)	`1`
Benchmark suite	Current: `0d1268d`	Previous: `b1b2a4f`	Ratio
`Retrieve AST from R code`	`254.70445752` ms (`48.56635699718653`)	`239.06656040000001` ms (`44.16598823989777`)	`1.07`
`Normalize R AST`	`19.45440952` ms (`14.953138748943163`)	`19.04988786` ms (`14.665186835895385`)	`1.02`
`Produce dataflow information`	`75.30514048` ms (`71.35653069164984`)	`72.05729572` ms (`67.06092157569653`)	`1.05`
`Total per-file`	`7850.45238692` ms (`28841.253371136383`)	`7652.55437492` ms (`28693.166726381678`)	`1.03`
`Static slicing`	`16.172304981916042` ms (`44.135225929438114`)	`15.882825839192575` ms (`43.82984820001617`)	`1.02`
`Reconstruct code`	`0.34529443588845116` ms (`0.1709415154465775`)	`0.24678118745144187` ms (`0.1433648958022132`)	`1.40`
`Total per-slice`	`16.52688720676753` ms (`44.1588873153231`)	`16.137227556865618` ms (`43.86167991198577`)	`1.02`
`failed to reconstruct/re-parse`	`0` #	`0` #	`1`
`times hit threshold`	`0` #	`0` #	`1`
`reduction (characters)`	`0.8712997340230448` #	`0.8712997340230448` #	`1`
`reduction (normalized tokens)`	`0.8102441553774778` #	`0.8102441553774778` #	`1`
`memory (df-graph)`	`99.4425` KiB (`113.62933451202426`)	`99.4425` KiB (`113.62933451202426`)	`1`