Merge pull request #28 from flownative/task/php-8.3

Try to build 8.3.0-RC5 but load sources as 8.3.0RC5
flownative · Nov 7, 2023 · 0b7ea2c · 0b7ea2c
2 parents 4b1c864 + 57a23e5
commit 0b7ea2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/docker.build.yaml b/.github/workflows/docker.build.yaml
@@ -12,7 +12,7 @@ jobs:
   build:
     strategy:
       matrix:
-        php: [ 7.4.33, 8.0.30, 8.1.25, 8.2.12, 8.3.0RC5 ]
+        php: [ 7.4.33, 8.0.30, 8.1.25, 8.2.12, 8.3.0-RC5 ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/root-files/build.sh b/root-files/build.sh
@@ -118,7 +118,8 @@ build_compile_php() {
     local php_source_url
 
     if [[ "${PHP_VERSION}" =~ ^8.3 ]]; then
-        php_source_url="https://downloads.php.net/~jakub/php-${PHP_VERSION}.tar.gz"
+        # different source and replace - separator in version against what PHP uses (i.e. nothing)
+        php_source_url="https://downloads.php.net/~jakub/php-${PHP_VERSION/-/}.tar.gz"
     else
         php_source_url="https://www.php.net/distributions/php-${PHP_VERSION}.tar.gz"
     fi