Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson to version 2.10.1 #1947

Conversation

PascalSchumacher
Copy link
Contributor

@PascalSchumacher PascalSchumacher commented Sep 20, 2019

Jackson 2.10 was just released and will be used by Spring 5.2 and Spring Boot 2.2.

@PascalSchumacher
Copy link
Contributor Author

I guess the change to HttpServiceTaskTest#testDeleteResponseEmptyBody is not correct. Probably the implementation has to be changed instead to keep the old behavior.

The reason for the behavior change should be one of the Null related changes listed in https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10 (maybe FasterXML/jackson-databind#2430).

@filiphr
Copy link
Contributor

filiphr commented Sep 20, 2019

It probably is that. However, I think that we should fix it in the implementation side not in the test.

Perhaps in https://github.com/flowable/flowable-engine/blob/c0f05e8c682ded61035a5076ff66ad97524772aa/modules/flowable-http/src/main/java/org/flowable/http/HttpActivityExecutor.java#L118 and check if the return type is NullNode.

Or adapt JsonType

@PascalSchumacher
Copy link
Contributor Author

Thanks Phillip!

I have updated the pull request and changed the implementation instead of the test (not sure if this is the best solution).

The correct Jacksons issue is Change of behavior (2.8 -> 2.9) with ObjectMapper.readTree(input) with no content, see: FasterXML/jackson-databind#2211

@PascalSchumacher PascalSchumacher changed the title PoC: Update Jackson to version 2.10.0.pr3. Update Jackson to version 2.10.0 Sep 24, 2019
@PascalSchumacher PascalSchumacher force-pushed the update_jackson_to_2_10_0 branch 4 times, most recently from 0efd9d4 to 341ca60 Compare September 27, 2019 15:17
@PascalSchumacher PascalSchumacher changed the title Update Jackson to version 2.10.0 Update Jackson to version 2.10.1 Nov 11, 2019
…response with no content.

Jackson 2.10 changed the behavior for ObjectMapper.readTree(input) for no content (see: FasterXML/jackson-databind#2211).
@tijsrademakers
Copy link
Contributor

Thanks for the PR, merged the changes in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants