Fix TypeScript type definitions #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s no need to use `declare module`. This is only useful to declare modules that don’t match the package name, e.g. to declare `fs` in `@types/node`. This is a CommonJS module that uses `module.exports =`. The correct type definition is `export =`. Technically the old type definitions work too, because `module.exports.default` is defined. However, with the new `"module": "node16"` option this means it should be used as follows in native ESM: ```ts import Concat from 'concat-with-sourcemaps' new Concat.default(true, 'all.js') ``` This is typically undesirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s no need to use
declare module. This is only useful to declare modules that don’t match the package name, e.g. to declarefsin@types/node.This is a CommonJS module that uses
module.exports =. The correct type definition isexport =.Technically the old type definitions work too, because
module.exports.defaultis defined. However, with the new"module": "node16"option this means it should be used as follows in native ESM:This is typically undesirable.