Fixed Android banner rendering issue. #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the Cordova Webview scales to take up the entire width and height of the Android screen. A change was made to set its height to flex to take up the entire remaining free vertical space, instead of taking all of it. This change was made because the AdView, when at the bottom of the screen, was "bumping" up the WebView to take it's space. This bumping only happened after layout in the WebView, which caused fullscreen WebView content to visually jump up. Oddly this happened after every reflow inside of the WebView, so on every page change you had the content "bump" up. For some reason this change only fixes Android versions > 4.1. I cannot figure out why it isn't helping on version <= 4.1. The half solution for now is better than none at all though.
The previous commit was causing a crash because a change to the UI thread wasn't run inside Androids special runOnUiThread method. This error got passed me because I had tested an earlier version where I changed the main UI late when showing a banner ad, instead of on initializing the plugin, and for some reason the version that doesn't force the setLayout call to run on the UI thread works in my app. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the Cordova Webview scales to take up the entire width and
height of the Android screen. A change was made to set its height to
flex to take up the entire remaining free vertical space, instead of
taking all of it. This change was made because the AdView, when at the
bottom of the screen, was "bumping" up the WebView to take it's space.
This bumping only happened after layout in the WebView, which caused
fullscreen WebView content to visually jump up. Oddly this happened
after every reflow inside of the WebView, so on every page change you
had the content "bump" up.
For some reason this change only fixes Android versions > 4.1. I
cannot figure out why it isn't helping on version <= 4.1. The half
solution for now is better than none at all though.