feat: implement git backend environments storage #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
force-pushed
the
gm/v2-environments-storage
branch
from
cd8920c to
90b12c2
Compare
GeorgeMac
force-pushed
the
gm/v2-environments-storage
branch
from
90b12c2 to
8b9280b
Compare
dosubot
bot
added
the
size:XXL
markphelps
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #3832
Merging this means that main does not compile yet (on v2).
This is due to the fact that I need to fixup the wiring for legacy APIs (flags and eval), which now need to handle the fact there is no concepts of environments (need to support a default env + env switching header).
That said, this introduces the functionality for reading and writing flag state to a single target branch (i.e. trunk / main etc).
It brings in the environment store along with a git implementation that supports being backed either by memory or the local filesystem.