-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FL-3453] NFC Logger #4039
Draft
RebornedBrain
wants to merge
143
commits into
flipperdevices:dev
Choose a base branch
from
RebornedBrain:reborned/nfc_logger_plugin
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[FL-3453] NFC Logger #4039
RebornedBrain
wants to merge
143
commits into
flipperdevices:dev
from
RebornedBrain:reborned/nfc_logger_plugin
+4,923
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Note
Now all protocols saves their history as binary data, but they need protocol specific formatters to be added, in order to be
displayed in human readable format. Below there is a list of protocols which are now formatted.
Supported protocols:
ToDo:
Verification
By default logger is disabled and doesn't impact NFC flow.
Poller test:
ext/nfc/log
LOG-yyyymmdd-hhmmss.txt
, you will see logsListener test:
ext/nfc/log
LOG-yyyymmdd-hhmmss.txt
, you will see logsChecklist (For Reviewer)