Make Autotools work out of tree #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-breaking: Now, paths with spaces are no longer allowed. However, this should not really be breaking as Make does not allow spaces by default (although, one *could* make it work in some cases by hacking).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #30.
Note, however, that paths with spaces are no longer allowed. While @edgarcosta fixed this half a year ago, I could not get quoted path to work for recipes. According to [1], one could escape these via double backslash, such as
but it's not really consistent. Regardless, if you want to build FLINT with paths containing spaces, you would probably want to do the same for GMP, which I believe does not work.
If someone manage to get paths with spaces to work, please submit a PR or let me know how to fix this. Until then, I am more in favor of this PR.