-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch signals for graceful fleet desktop exit #23054
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23054 +/- ##
==========================================
- Coverage 63.35% 63.34% -0.01%
==========================================
Files 1534 1534
Lines 144300 144300
Branches 3650 3650
==========================================
- Hits 91417 91414 -3
+ Misses 45671 45668 -3
- Partials 7212 7218 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Double checking: Should we update our https://github.com/fyne-io/systray version? (there's this related commit) |
We could for sure, we'd just need to add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few questions.
#21256
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.