Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch signals for graceful fleet desktop exit #23054

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Oct 21, 2024

#21256

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • For Orbit and Fleet Desktop changes:
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.34%. Comparing base (fb0f69c) to head (5c29e4a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23054      +/-   ##
==========================================
- Coverage   63.35%   63.34%   -0.01%     
==========================================
  Files        1534     1534              
  Lines      144300   144300              
  Branches     3650     3650              
==========================================
- Hits        91417    91414       -3     
+ Misses      45671    45668       -3     
- Partials     7212     7218       +6     
Flag Coverage Δ
backend 64.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review October 22, 2024 19:32
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner October 22, 2024 19:32
@lucasmrod
Copy link
Member

Double checking: Should we update our https://github.com/fyne-io/systray version? (there's this related commit)

@dantecatalfamo
Copy link
Member Author

Double checking: Should we update our https://github.com/fyne-io/systray version? (there's this related commit)

We could for sure, we'd just need to add an os.Exit(0) at the end of onExit. Maybe in another PR?

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants